Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[add_data_table] improve rowNames. closes #354 #375

Merged
merged 5 commits into from
Oct 26, 2022
Merged

Conversation

JanMarvin
Copy link
Owner

@JanMarvin JanMarvin commented Oct 13, 2022

Previously, when using rownames = TRUE when writing data, we would add a cell with 1 in top left box (the name for the rownames). This has been changed:

  • when writing data: we do not fill this cell at all.
  • when writing a data table: we fill this cell with _rowNames_.

IIRC data tables require unique column names and can not be empty.

  • test with Excel
  • add unittests
  • update NEWS
wb <- wb_workbook()

wb$add_worksheet()$add_data(x = mtcars, rowNames = TRUE)
wb$add_worksheet()$add_data_table(x = mtcars, rowNames = TRUE)

wb$open()

@JanMarvin JanMarvin added the enhancement 😀 New feature or request label Oct 13, 2022
@JanMarvin JanMarvin mentioned this pull request Oct 18, 2022
5 tasks
@JanMarvin JanMarvin merged commit c6b73d2 into main Oct 26, 2022
@JanMarvin JanMarvin deleted the gh_issue_354 branch October 26, 2022 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 😀 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant