fix: map loguru log levels to stdlib equivalents in worker subprocess#357
Merged
Conversation
The parent process passes FGC_LOG_LEVEL (a loguru level) to the worker subprocess, which uses stdlib logging. Loguru-specific levels like TRACE crash the worker with "Unknown level" ValueError, preventing app manifest fetches from completing.
Member
|
Should we maybe switch the worker process to use loguru in the future? But I know @neomorphic was worried about import size. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parent process passes FGC_LOG_LEVEL (a loguru level) to the worker subprocess, which uses stdlib logging. Loguru-specific levels like TRACE (used in my local dev mode, which is where I discovered the bug) crash the worker with "Unknown level" ValueError, preventing app manifest fetches from completing.
@krokicki