Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add check that hash is not equal to "#" in matchInPanel function #36

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
2 participants

There was an odd edge case where the hash variable could end up as just "#" if the url was structured like "url.com#?query=query" (note the "#?"). This caused Sizzle (jQuery) to throw an error when called as an argument like ":has(#)". Might be better to look at fixing the regex so it can't match just a "#", but this was a pretty quick fix to just check against "#".

localpcguy added some commits Mar 23, 2012

@localpcguy localpcguy Add check that hash is not equal to "#" in matchInPanel (breaks jQuer…
…y in an instance where the hash = "#?query=query")
1a3bf47
@localpcguy localpcguy Add check that hash is not equal to "#" in matchInPanel (breaks jQuer…
…y in an instance where the hash = "#?query=query")
274fb9c
@localpcguy localpcguy Add check if hash is empty to fix an IE7 bug that was showing that $s…
…electedTab was an element when the hash was empty, and so ignoring the defaultTab setting and causing an error
c448f55
@localpcguy localpcguy Add check if hash is empty to fix an IE7 bug that was showing that $s…
…electedTab was an element when the hash was empty, and so ignoring the defaultTab setting and causing an error
76ac3af
@localpcguy localpcguy Merge branch 'master' of github.com:localpcguy/jQuery-EasyTabs a3e5090
Owner

JangoSteve commented May 9, 2013

Hey, thanks for the pull request Mike! Sorry I know this was submitted a year ago. I think this has actually been fixed though in this commit (17ee0f3), which was meant to fix the problem where some other plugins would do a push-state fallback by updating the hash in the URL with something like #/page or #!/page which would break easytabs.

@JangoSteve JangoSteve closed this May 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment