Fix confilcts with other Gems #45

Merged
merged 1 commit into from Feb 9, 2013

5 participants

@vivrass

If we use remotipart with wicked_pdf, the javascript returned by create.js.erb won't be executed after the request.

When using alias_method_chain, we let another gem to be able to override the "render" method on ActionController::Base.

@ehoch

Wow this fix just rescued me from wicked_pdf / remotipart hell! @JangoSteve Can we get this fix in and a new gem ver pushed out?

@ehoch ehoch referenced this pull request in sferik/rails_admin Dec 4, 2012
Closed

Jquery json error when using with wicked_pdf #1419

@ScotterC

👍 This needs to be merged. Thanks @vivrass !

@vivrass

I'm glad my fix helped you guys.

@mattmoskwa

Just wanted to +1 this. I can't figure out which gem of mine is conflicting, but this helped me after many many hours of googling and head-desking. Needs to be merged ASAP.

@JangoSteve
Owner

Oh I like this better anyway. Can you please rebase this without the .on commit since that's already been fixed in v1.0.3?

@vivrass

Thank you for the answer. I just rebased my branch on master.

@JangoSteve JangoSteve merged commit b0073a1 into JangoSteve:master Feb 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment