Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sharing access to your container ports to enable live collaboration (IDE, VNC, web preview...) #182

Open
jankeromnes opened this issue Oct 27, 2017 · 5 comments

Comments

@jankeromnes
Copy link
Member

@jankeromnes jankeromnes commented Oct 27, 2017

@jankeromnes
Copy link
Member Author

@jankeromnes jankeromnes commented Nov 6, 2017

The --collab argument was added in JanitorTechnology/dockerfiles@acc5035.

Now we can try to use the IDE in collaborative mode / figure out how to make the feature easy to use.

@jankeromnes
Copy link
Member Author

@jankeromnes jankeromnes commented Nov 28, 2017

It could be done by allowing other users to access your container ports, and then giving them the same URL you're using, e.g. https://pianosa.janitor.technology/abcd1234/8089/

In the above example, if you don't own the container abcd1234, the Docker host's API call to https://janitor.technology/api/hosts/pianosa.janitor.technology/containers/abcd1234/3000 will result in a 404 error.

We could tweak this API handler to check an access list (which could be edited by container owners using a new API handler for sharing containers) instead of just verifying container ownership.

@jankeromnes jankeromnes changed the title Enable and expose Cloud9's collaboration mode Allow sharing access to your container ports to enable live collaboration (IDE, VNC, web preview...) Nov 30, 2017
@nt1m
Copy link
Member

@nt1m nt1m commented Mar 6, 2018

A quick little mockup of how this feature can look like:

screen shot 2018-03-06 at 02 25 51

@jankeromnes
Copy link
Member Author

@jankeromnes jankeromnes commented Mar 6, 2018

Thanks a lot for this mockup! It's perfect 😄 I want this feature so bad...

Random thought: If we have a URL that can point to a specific container and a specific tab, we could potentially redirect Cloud9 IDE's "Share" button to this panel in Janitor.

Edit: Maybe something like https://jntr.io/containers/#abcdef0123456-share? Would probably require some JS though, unfortunately.

@jankeromnes
Copy link
Member Author

@jankeromnes jankeromnes commented Mar 6, 2018

@bnjbvr would also like a feature to "share publicly" 😄 (I'm thinking maybe port-specific, e.g. just share a web preview but not Cloud9 IDE, and with a secret URL).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants