Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Implement a Discourse-backed blog page #208
How it works
Create the topic in the Newsletter category. If you don't tag it as
Also, the webhook payload is not read, and the signature is not validated. So you can manually trigger a poll by pointing your browser at that URL.
Importing old entries
The "slug" in Discourse, which can be seen in the URL, becomes the
Also, you can click the admin wrench and change the topic timestamp. The Janitor's blog page sorts posts by their timestamp, so old newsletter entries will line get sorted correctly.
4 times, most recently
Dec 14, 2017
changed the title from
New blog page
Implement a Discourse-backed blog page
Dec 15, 2017
added a commit
this pull request
Dec 15, 2017
Just a few more comments in passing. Thanks again for implementing this!
Thanks again for this very cool new blog page!
I was finally able to make a pass on the code (sorry for the delay, I was away for the holidays. Also, happy new year!
I haven't yet looked too closely at the visual result (although I remember it looks really nice now, and I'm super happy that we'll finally have a Comment feature), and believe I'll have a few nits there as well, but since it already looks very nice and also the page won't be publicly exposed at first, we can also leave any adjustments for later without further delaying this pull request.
Please have a look at my nits below (sorry for being extremely nit-picky...). They're mostly about being consistent with the coding style in the rest of the code base, adding a few comments here and there.
And again, huge
Thanks a lot for working so hard on improving this pull request! I'm running out of things to complain about, but I couldn't resist publishing another round of nits (I'm very sorry about them).
After that, I guess the last big complaint I might have about this feature is the security aspect of fully trusting imported Discourse HTML, but maybe I'm making too big a deal out of this. I guess I should try to exploit it, and then if I fail, I should stop complaining.
R+ with nits, thanks!
I'm OK with this being merged, but before merging, please fix the few nits below.