New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New data page #254
New data page #254
Conversation
ar5had
commented
Feb 1, 2018
Wow, this looks great! A few quick comments off hand:
|
templates/data-new.html
Outdated
<h3>Containers</h3> | ||
<p class="numbers"> | ||
<span class="number">{{= data.contributions.started in integer}}</span> | ||
<span class="unit">started</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jankeromnes I have removed the merged
status. I hope this is what you meant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, perfect. Thank you! 😄
#253 needs to be merged before this pr. I will then have to update this pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks! I approve this change, but please remove the 404 page commit from your branch, e.g. with:
git fetch origin
git rebase -i origin/master
- (delete the line with the unrelated 404 page commit)
- (save the file)
static/css/janitor-new.css
Outdated
border-bottom: none; | ||
} | ||
|
||
.data div:last-child::after { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment with what this represents ? Also, I think .data::after
might be better, because right now, it kinda makes an assumption that it has a link with :last-child
when it really doesn't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but as I said, add a comment, it's not explicit. Also, can you just put this on .data::after
?
static/css/janitor-new.css
Outdated
} | ||
|
||
.data div:nth-child(4), | ||
.data div:nth-child(5) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is :nth-child(5)
used ? Also, can you use .data-topic instead of div
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit: I should use nth-f-type instead.
static/css/janitor-new.css
Outdated
|
||
.data .data-topic { | ||
flex: 0 1 50%; | ||
/* background: red; */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove this leftover
static/css/janitor-new.css
Outdated
.data-topic .number { | ||
font-size: 18px; | ||
font-weight: 700; | ||
color: #0c9100; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use a photon color :) https://design.firefox.com/photon/visuals/color.html
Since .Data consists of h1 and data topics, therefore positioning this
element will be complicated. Feel free to try it urslf.
…On 3 Feb 2018 4:12 pm, "Tim Nguyen" ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In static/css/janitor-new.css
<#254 (comment)>
:
> +}
+
+.data-topic span.unit:nth-child(2) {
+ margin-right: 10px;
+}
+
+.data .data-topic:nth-child(2n-1) {
+ border-right: none;
+}
+
+.data div:nth-child(4),
+.data div:nth-child(5) {
+ border-bottom: none;
+}
+
+.data div:last-child::after {
Yeah, but as I said, add a comment, it's not explicit. Also, can you just
put this on .data::after ?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#254 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AQCl1lV0EgLmXOngwuNAR-w9hlALM9hgks5tRDgCgaJpZM4R1L2u>
.
|
@arshdkhn1 Alright, I'm fine with using |
c3d00c4
to
8e9670c
Compare
1f3087d
to
8eb444a
Compare