Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1066 - Fixed automatic type detection issue for edge properties #1126

Merged

Conversation

prithvinambiar
Copy link
Contributor

@prithvinambiar prithvinambiar commented Jun 18, 2018

Issue #1066

  1. getOrCreatePropertyKey was getting called without the value and hence the code in the following file was not getting executed - JanusGraphDefaultSchemaMaker.java#L44. This resulted in the edge properties not having automatic type detection.

  2. Added JUNIT tests for vertex and edge properties to verify auto data type detection

Signed-off-by: Prithvi Nambiar prithvinambiar@gmail.com


Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there an issue associated with this PR? Is it referenced in the commit message?
  • Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you written and/or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
  • If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?
  • If this PR is a documentation-only change, have you added a [skip ci]
    tag to the first line of your commit message to avoid spending CPU cycles in
    Travis CI when no code, tests, or build configuration are modified?

Note:

Please ensure that once the PR is submitted, you check Travis CI for build issues and submit an update to your PR as soon as possible.

… properties

Signed-off-by: Prithvi Nambiar <prithvinambiar@gmail.com>
@janusgraph-bot janusgraph-bot added the cla: no This PR is not compliant with the CLA label Jun 18, 2018
@janusgraph-bot
Copy link

Committer of one or more commits is not listed as a CLA signer, either individual or as a member of an organization.

@pluradj pluradj added this to the Release v0.2.1 milestone Jun 19, 2018
Copy link
Member

@pluradj pluradj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @prithvinambiar

We'll have to wait for the CLA checker to go green before merging, but I know your CLA is in progress.

@pluradj pluradj requested a review from a team June 19, 2018 19:20
@janusgraph-bot janusgraph-bot added cla: yes This PR is compliant with the CLA and removed cla: no This PR is not compliant with the CLA labels Jun 19, 2018
Copy link
Contributor

@sjudeng sjudeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice job on the tests.

@pluradj pluradj merged commit 9388078 into JanusGraph:0.2 Jul 9, 2018
@palwe-prafulla
Copy link

I observed this issue with edge property where we added property value as Integer but when I try to access the edge with property value with int through grrmlin, it doesnt give anything back where as if I use '' to make it string it gives it back.
Also my java application code returns the edge with this property value as of type String class next time i retrieve edge after creation.
This is on 0.2.0

However, I also observed the similar issue on vertex.
I created vertex with integer property value but when trying to get it through gremlin with int value it throws error indicating type need to be string.

Just wondering if this issue is applicable for vertex properties as well (may be specific to Integer values?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This PR is compliant with the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants