Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd dependency on commons-lang3. #321
Merged
Conversation
timlevett
pushed a commit
that referenced
this pull request
May 13, 2014
Add dependency on commons-lang3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
apetro commentedMay 13, 2014
Adds Maven dependency on
commons-lang3.Apparently this dependency was available through a transitive dependency, and some Marketplace-and-related code is already trying to use Commons Lang 3, but it wasn't actually a dependency in uPortal. This change makes it one.
Does not disrupt commons-lang 2
commons-lang3uses a different package than does oldcommons-lang(2), such that adding lang3 doesn't disrupt dependency on and usage of lang2. Isn't that nice? :)Deferred work: