Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUP-4107: Set focusedFolderId (was focusedFragmentId) only for 'favorites_collection' type folders #327
Conversation
| @@ -68,7 +68,7 @@ | |||
| <xsl:choose> | |||
| <xsl:when test="not(//folder/channel[@ID = $userLayoutRoot]) | |||
| and $focusedTabID!='none' | |||
This comment has been minimized.
This comment has been minimized.
… properly point focusedFolderId at a favorites_collection in the right circumstances
|
@wiscu folks -- This change fixes UP-4107, and I have verified that I can properly view the 'News' favorite_collection in the quickstart data set. |
apetro
changed the title
apetro
changed the title
|
Nice fix. I think there'd been some aspirations for building technology for focusing on non-regular-type folders applicable beyond |
apetro
added a commit
that referenced
this pull request
May 27, 2014
UP-4107 : Set focusedFolderId (was focusedFragmentId) only for 'favorites_collection' type folders.
|
Looks great, thanks @drewwills ! |
vertein
added a commit
that referenced
this pull request
Jul 8, 2015
MUMUP-1750 /apps cache lasts longer than 5 minutes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
drewwills commentedMay 23, 2014
@wiscu folks -- Would this change break any of the favorites tech? I don't understand a lot about the focusedFragmentId, except that it's triggering UP-4107.