Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UP-4148 Update CONTRIBUTING.md #461

Merged
merged 14 commits into from Nov 12, 2014
Merged

Conversation

apetro
Copy link
Member

@apetro apetro commented Nov 11, 2014

See UP-4148. This is a retry of PR #347 , differing from that in that this version does not include a change to the recommended branch naming convention.

Updates CONTRIBUTING.md to

  • Emphasize the necessity of the Individual Contributor License Agreement (ICLA).
  • Suggest communicating about proposed changes via uportal-dev@ and uportal-user@.
  • Request that code consider style conventions and uPortal architecture.
  • Suggest sharing and collaborating in a public feature branch in advance of pull request.
  • Standardize on "JIRA" vs "Jira".
  • Fix "inclusing" and "commiting" typos.
  • Remove extraneous within-paragraph newlines. Add newlines after section headings.

The change to a branch naming convention that would supplement the bare issue identifier in the name with a hint about what the branch is about (UP-4148-contributing vs UP-4148) is dropped because there had been concern that long branch names might be annoying.

@drewwills
Copy link
Contributor

Looks like an improvement 👍

@jameswennmacher
Copy link

Looks good. (I like longer branch names too :-) )

@apetro
Copy link
Member Author

apetro commented Nov 12, 2014

@jameswennmacher Yup. Could go after that in a separate Pull Request if desired. Looking to get the uncontroversial improvements adopted through this one.

@timlevett
Copy link
Contributor

👍

timlevett pushed a commit that referenced this pull request Nov 12, 2014
UP-4148 Update CONTRIBUTING.md
@timlevett timlevett merged commit 49c0490 into uPortal-Project:master Nov 12, 2014
@apetro apetro deleted the UP-4148 branch May 8, 2018 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants