Arm stay silent - but encoding bug too? #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original point of this branch was to allow a new command:
concord232_client arm-stay-silent
which is the equivalent of pressing "5" "2" on the keypad. I did implement this, but in the course of things discovered what seems to be a fairly major bug. In the encoding from binary to ascii, python uses lowercase for the hex letters. But the automation panel seems not to accept this, but rather only uppercase letters. The protocol manual does seem to specify this, if not all that clearly, when they say:
"Only sixteen ASCII characters '0'...'9', 'A'...'F' are used to transfer data."
I am not sure if you are still interested in maintaining this, but I thought I'd make the pull request and see what you think.