Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved footer stick to the bottom of the page #72

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@abdiG
Copy link

commented Apr 14, 2019

I moved sticker code to the to a Footer.js file. I think it will make things easier if you guys wanted to add more things to the footer. let me know if you don't like it or if there is something wrong with the code.
fixed #46

@abdiG abdiG referenced this pull request Apr 14, 2019

Closed

make footer stick to bottom #46

position:absolute;
bottom:0;
width:100%;
}

This comment has been minimized.

Copy link
@cdrani

cdrani Apr 14, 2019

Collaborator

Hi @abdiG: Thanks for making this PR. I am more than happy to accept this PR with some slight changes:

  1. Change the .py-3 class name to something like fixed-footer to be more meaningful. .py-3 is used by bootstrap to add something like:
  padding-top: 3(units);
  padding-bottom: 3(units);
  1. Add spacing between the css property and value as shown in the above classes:
  position: absolute;
  bottom: 0;
  width: 100%;

You would currently be overriding the preset bootstrap class, which is not recommended.As an alternative to 2), try to find a bootstrap class that already does the above and remove the above css altogether.

  1. Prettify the Footer component as it was before. Is the pre-commit hook not running for you? The hook should prettify your code before it can be committed.

I would also suggest a change in the color of the text, but I believe that's being addressed in #70.

@JasonFritsche

This comment has been minimized.

Copy link
Owner

commented Apr 15, 2019

This issue was solved by @RocktimSaikia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.