New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting room shape causes crash #394

Closed
ThePix opened this Issue Jan 23, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@ThePix
Contributor

ThePix commented Jan 23, 2018

This is an issue with the version of Trizbort source as downloaded from Github 22/Jan/18, running through VS2017 on Windows 7.

Create a new room, and double click on it to bring up properties. Click Okay, and the shape changes to rounded corners.

You can change the shapes of rooms via the menu. However, if you go to properties, it will tell you it is actually the next one down the list, and when you click okay, it will become that shape. Going back to properties will show that same shape

Double clicking an octagonal room (set from the menu) throws an exception, line 119, RoomPropertiesDialog.cs, presumabbly because there is no next shape to turn it in to.

Similarly, trying to set the shape to square from the properties throwing an exception at line 1624 of Room.cs, because it is trying to go beyond the start of the list?

It is like the properties dialogue sets one value and the menu sets another, and they are out of step.

Maybe unrelated, but there are no regions listed in the properties dialogue

@JasonLautzenheiser JasonLautzenheiser self-assigned this Jan 27, 2018

@JasonLautzenheiser JasonLautzenheiser added this to the 1.6.0.0 milestone Jan 27, 2018

JasonLautzenheiser added a commit that referenced this issue Jan 27, 2018

Merge pull request #396 from JasonLautzenheiser/394-room-shape
fix (rooms) - room shapes were calculated incorrectly - Fixes #394
@JasonLautzenheiser

This comment has been minimized.

Owner

JasonLautzenheiser commented Jan 27, 2018

@ThePix The room issue should be fixed if you get the latest code.

I've not been able to reproduce the issue with regions. If you go to map settings and add regions, then go to the properties dialog, they should show up. Note, there are no regions by default on a new map. If this is still not working, there must be a strange scenario that I'm not seeing and we can open a new issue with that.

@ThePix

This comment has been minimized.

Contributor

ThePix commented Jan 27, 2018

I did not see where to set up regions, so that was my bad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment