Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
branch: master
Commits on Feb 9, 2010
  1. This repo is now obsolete

    Jason Woofenden authored
Commits on Feb 5, 2010
  1. @dodamn

    Add 'track-preferred' and 'album-preferred' for replaygain option.

    dodamn authored Jason Woofenden committed
    When replaygain is set to 'track-preferred', album gain will be used
    instead if track gain is unavailable. In other words, track gain will be
    preferred over album one if available.
    Similarly when replaygain is set to 'album-preferred', track gain will be used
    instead if album gain is unavailable.
    Just in case you want to know, 'disabled, 'track' and 'album' were
    only available for replaygain. When replaygain is set to 'track'(or 'album'),
    only track gain(or album gain) will be used. If track gain(or album gain) is
    unavailable, nothing will be gained.
  2. @flyingmutant

    tree: fix album sorting

    flyingmutant authored Jason Woofenden committed
    Comparing album dates before checking for special album name is wrong.
    
    Signed-off-by: Gregory Petrosyan <gregory.petrosyan@gmail.com>
  3. @flyingmutant

    Make track_info_is_compilation() more robust

    flyingmutant authored Jason Woofenden committed
    Compare 'artist' and 'album artist' tags case-insensitively.
    
    Signed-off-by: Gregory Petrosyan <gregory.petrosyan@gmail.com>
  4. @flyingmutant

    tree: assign '<No Name>' name to tracks with empty album/artist name …

    flyingmutant authored Jason Woofenden committed
    …tags
    
    Signed-off-by: Gregory Petrosyan <gregory.petrosyan@gmail.com>
  5. @flyingmutant

    id3: ignore TPE2 frames if we already know 'album artist'

    flyingmutant authored Jason Woofenden committed
    Many taggers write e.g. TPE2 equal to TPE1, and write 'album artist' in TXXX
    frame. This patch makes cmus prefer non-TPE2 'album artist' sources over TPE2.
    
    Signed-off-by: Gregory Petrosyan <gregory.petrosyan@gmail.com>
  6. @flyingmutant

    id3: add RVA2 (replaygain) frames support

    flyingmutant authored Jason Woofenden committed
    Signed-off-by: Gregory Petrosyan <gregory.petrosyan@gmail.com>
  7. @flyingmutant

    id3.c: fix strncmp arg

    flyingmutant authored Jason Woofenden committed
    Signed-off-by: Gregory Petrosyan <gregory.petrosyan@gmail.com>
  8. @flyingmutant

    id3.c: clean up v2_read() a bit

    flyingmutant authored Jason Woofenden committed
    Signed-off-by: Gregory Petrosyan <gregory.petrosyan@gmail.com>
  9. @flyingmutant

    id3.c: don't unsync frames twice

    flyingmutant authored Jason Woofenden committed
    This fixes id3 tag parsing in case both frame header and frame have 'unsync'
    flag set.
    
    Signed-off-by: Gregory Petrosyan <gregory.petrosyan@gmail.com>
  10. @flyingmutant

    id3.c: handle V2_FRAME_LEN_INDICATOR properly

    flyingmutant authored Jason Woofenden committed
    This fixes id3 frame parsing in case length indicator is present.
    
    Signed-off-by: Gregory Petrosyan <gregory.petrosyan@gmail.com>
  11. @flyingmutant

    id3.c: simplify utf16_is_special()

    flyingmutant authored Jason Woofenden committed
    Signed-off-by: Gregory Petrosyan <gregory.petrosyan@gmail.com>
  12. @flyingmutant

    id3.c: remove stale #if

    flyingmutant authored Jason Woofenden committed
    Signed-off-by: Gregory Petrosyan <gregory.petrosyan@gmail.com>
  13. @flyingmutant

    id3: move id3_init() from .h to .c

    flyingmutant authored Jason Woofenden committed
    Signed-off-by: Gregory Petrosyan <gregory.petrosyan@gmail.com>
  14. @flyingmutant

    id3: move special UTF16_* macros from .h to .c

    flyingmutant authored Jason Woofenden committed
    While at it, convert macros to static inline functions.
    
    Signed-off-by: Gregory Petrosyan <gregory.petrosyan@gmail.com>
  15. @flyingmutant

    id3.h: add missing newline

    flyingmutant authored Jason Woofenden committed
    Signed-off-by: Gregory Petrosyan <gregory.petrosyan@gmail.com>
  16. @flyingmutant

    debug.h: remove #ifdef magic and extra #include directives

    flyingmutant authored Jason Woofenden committed
    As a positive side effect, arguments of d_print() and BUG() are always
    evaluated.
    
    Signed-off-by: Gregory Petrosyan <gregory.petrosyan@gmail.com>
Commits on Jan 31, 2010
  1. @flyingmutant

    Makefile: clean Doc/*.7 as well

    flyingmutant authored
    Signed-off-by: Gregory Petrosyan <gregory.petrosyan@gmail.com>
  2. @flyingmutant

    README: remove stale reference to first-time-tutorial.txt

    flyingmutant authored
    While at it, add some missing newlines.
    
    Signed-off-by: Gregory Petrosyan <gregory.petrosyan@gmail.com>
  3. @flyingmutant

    Doc: man-ification of cmus-tutorial

    flyingmutant authored
    Signed-off-by: Gregory Petrosyan <gregory.petrosyan@gmail.com>
  4. @flyingmutant

    Doc/cmus.txt: bump up manual date

    flyingmutant authored
    Signed-off-by: Gregory Petrosyan <gregory.petrosyan@gmail.com>
  5. @flyingmutant

    Doc/cmus.txt: move 'LIBRARY VIEW SORTING' section down a bit

    flyingmutant authored
    'PLAYLIST EDITING', 'STATUS LINE' and 'KEYBINDINGS' sections are more
    concise and important for user.
    
    Cc: Frank Terbeck <ft@bewatermyfriend.org>
    Signed-off-by: Gregory Petrosyan <gregory.petrosyan@gmail.com>
Commits on Jan 24, 2010
  1. @mxpiotrowski

    Sort compilations by title instead of by year

    mxpiotrowski authored Jason Woofenden committed
    In the case of a "real" artist, chronological order makes perfect
    sense.  After all, it is common to talk about "their first album,"
    "their latest album," etc.
    
    In the case of compilations, however, it doesn't make sense.  If you
    have a number of compilations in your library, you look for them by
    name, not by the date of the first track, as a compilation may contain
    tracks from many different years.  Ordering compilations by the date
    of their first tracks effectively puts them into a random order, and
    it also leads to series of compilations getting broken up, e.g.,
    
       ...
       Back To Mine compil...
       Easy Tempo Vol. 2: ...
       Easy Tempo Vol. 6: ...
       The Old Grey Whistl...
       Easy Tempo Vol. 1: ...
       Easy Tempo Vol. 9: ...
       Mojo Club Dancefloo...
       ...
    
    This patch causes albums filed under <Compilations> to be sorted
    alphanumerically by title.  It does not change the sort order for
    albums with ALBUMARTIST set.
Commits on Jan 1, 2010
  1. Use pthread_cond_* while waiting for beginning of playback.

    dead_orc authored Jason Woofenden committed
    I don't know if this is "the proper way to do it", but it seems to work
    all right for me.
    
    This reduces the wakeups caused by cmus while not playing anything from
    ~50 to 2 per second.
  2. @flyingmutant

    pulse: drain stream in op_pulse_close()

    flyingmutant authored Jason Woofenden committed
    PA bug that resulted in hang can be worked around by draining stream
    without extra lock held. So be it.
    
    This kind-of reverts commit ac0f0de.
    
    PA-trac: http://pulseaudio.org/ticket/725
    Signed-off-by: Gregory Petrosyan <gregory.petrosyan@gmail.com>
  3. @flyingmutant

    pulse: disable high-latency mode

    flyingmutant authored Jason Woofenden committed
    Since it is not clear when I'll be able to modify cmus to
    properly support high-latency output plugins, make pulse use
    buffer with more ALSA-like size.
    
    This patch makes pulse as fast and accurate at
    seeking/staring/stoping tracks as e.g. alsa.
    
    Signed-off-by: Gregory Petrosyan <gregory.petrosyan@gmail.com>
  4. @flyingmutant

    Make default format_trackwin_va more readable

    flyingmutant authored Jason Woofenden committed
    format_trackwin_va defaults to "artist before track" format, which is
    not very readable, e.g. (Eminem, "The Re-Up"):
    
    	01. Shady Narcotics
    	02. Eminem, Obie Trice, Stat Quo, Bobby Creekwater & Ca$his / We're Back
    	03. Obie Trice / Pistol Pistol (remix)
    	04. Bizarre & Kuniva / Murder
    	05. Ca$his / Everything Is Shady
    	06. Eminem & 50 Cent / The Re-Up
    	07. 50 Cent, Eminem, Ca$his & Lloyd Banks / You Don't Know
    	08. Eminem & 50 Cent / Jimmy Crack Corn
    	09. Proof / Trapped
    	10. Mr.  Porter & Swifty McVay / Whatever You Want
    	11. Ca$his / Talkin' All That
    	12. Stat Quo / By My Side
    	13. Obie Trice & Ca$his / We Ride for Shady
    	14. Bobby Creekwater / There He Is
    	15. Stat Quo / Tryin' Ta Win
    	16. Stat Quo & Bobby Creekwater / Smack That (remix)
    	17. Public Enemy #1
    	18. Stat Quo / Get Low
    	19. 50 Cent / Ski Mask Way (Eminem remix)
    	20. Nate Dogg, Eminem, Obie Trice & Bobby Creekwater / Shake That (remix)
    	21. Obie Trice, Kuniva, Bobby Creekwater, Ca$his & Stat Quo / Cry Now (Shady
    	22. No Apologies
    
    Change it to default to "track before artist" ("%t (%a)"), which makes
    searching visually for the right track much easier.
    
    Cc: Frank Terbeck <ft@bewatermyfriend.org>
    Signed-off-by: Gregory Petrosyan <gregory.petrosyan@gmail.com>
  5. @flyingmutant

    More robust compilation detection

    flyingmutant authored Jason Woofenden committed
    Do not treat tracks with "compilation" tag set to "0" and tracks with
    "albumartist" equal to "artist" as if they are compilations.
    
    Plus clean up code a bit.
    
    Cc: Frank Terbeck <ft@bewatermyfriend.org>
    Signed-off-by: Gregory Petrosyan <gregory.petrosyan@gmail.com>
  6. @flyingmutant

    flac: more robust error reporting

    flyingmutant authored Jason Woofenden committed
    Also fixes this warning:
    
    	flac.c: In function 'error_cb':
    	flac.c:356: warning: comparison of unsigned expression >= 0 is always true
    
    Signed-off-by: Gregory Petrosyan <gregory.petrosyan@gmail.com>
  7. @flyingmutant

    Fix error handling in key_unbind()

    flyingmutant authored Jason Woofenden committed
    The bug was found thanks to this GCC warning:
    
    	keys.c: In function 'key_unbind':
    	keys.c:539: warning: comparison of unsigned expression < 0 is always false
    
    Signed-off-by: Gregory Petrosyan <gregory.petrosyan@gmail.com>
  8. @flyingmutant

    Fix buffer length calculation in editable.c

    flyingmutant authored Jason Woofenden committed
    Looks like compiling with -Wextra is a good thing to do. This:
    
    	editable.c: In function 'keys_to_str':
    	editable.c:130: warning: comparison of unsigned expression < 0 is always false
    
    was triggered by a real bug (obtaining length of a buffer passed as
    "char *" argument with sizeof).
    
    In fact, even two bugs: comparison of unsigned expression < 0 is stupid
    indeed (and that happens because of C logic we all love).
    
    Signed-off-by: Gregory Petrosyan <gregory.petrosyan@gmail.com>
  9. @flyingmutant

    configure: bump up warning level

    flyingmutant authored Jason Woofenden committed
    Signed-off-by: Gregory Petrosyan <gregory.petrosyan@gmail.com>
  10. @flyingmutant

    Fix warn_unused_result warning in browser.c

    flyingmutant authored Jason Woofenden committed
    Signed-off-by: Gregory Petrosyan <gregory.petrosyan@gmail.com>
Commits on Dec 12, 2009
  1. tutorial: ascii art borders for screenshots

    Jason Woofenden authored
  2. tutorial tweaked

    Jason Woofenden authored
Something went wrong with that request. Please try again.