Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
J2V8 Result
# Pros
- With AndroidJSCore there was a problem with emoji support and
couldn’t do anything about it since it’s a low level thing. So
previously we used to just “censor” out unicode characters. J2V8
supports emojis (unicode) right out of the box!
- Smaller APK size than AndroidJSCore => Just tried building a signed
APK => It’d 9.8MB. Note that it’s larger than Duktape.
- No problem with regular expressions => This was the top reason I
decided to try J2V8, because Duktape wasn’t able to parse some JS
function calls at all due to its strict regular expression engine

# Cons
- Not much except that it’s larger than Duktape (9.8MB).

# Conclusion
9.8MB is still a significant improvement from 40MB, not to mention: 1.
Performance improvement; 2. Unicode support

Kind of leaning towards J2V8 unless there’s something I’m missing.
  • Loading branch information
gliechtenstein committed Dec 21, 2016
1 parent 2921915 commit a879c46
Show file tree
Hide file tree
Showing 3 changed files with 1,844 additions and 1,235 deletions.
2 changes: 1 addition & 1 deletion app/build.gradle
Expand Up @@ -28,7 +28,7 @@ dependencies {
compile 'com.squareup.okhttp3:okhttp:3.4.2'
compile 'com.github.bumptech.glide:glide:3.7.0'
compile 'jp.wasabeef:glide-transformations:2.0.1'
compile 'com.github.ericwlange:AndroidJSCore:3.0.1'
compile 'com.eclipsesource.j2v8:j2v8:4.5.0@aar'
compile 'com.android.support:recyclerview-v7:25.0.1'
compile 'com.android.support:design:25.0.0'
compile 'com.aurelhubert:ahbottomnavigation:2.0.2'
Expand Down

0 comments on commit a879c46

Please sign in to comment.