J2V8 #42
Merged
J2V8 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Pros - With AndroidJSCore there was a problem with emoji support and couldn’t do anything about it since it’s a low level thing. So previously we used to just “censor” out unicode characters. J2V8 supports emojis (unicode) right out of the box! - Smaller APK size than AndroidJSCore => Just tried building a signed APK => It’d 9.8MB. Note that it’s larger than Duktape. - No problem with regular expressions => This was the top reason I decided to try J2V8, because Duktape wasn’t able to parse some JS function calls at all due to its strict regular expression engine # Cons - Not much except that it’s larger than Duktape (9.8MB). # Conclusion 9.8MB is still a significant improvement from 40MB, not to mention: 1. Performance improvement; 2. Unicode support Kind of leaning towards J2V8 unless there’s something I’m missing.
add $convert.csv feature for #18
add $convert.rss feature
|
HUUUUGE Update! Thanks @brad ! Need to update the parser JS file a bit and then close the issue soon! |
|
@gliechtenstein What sort of difference does this make in terms of apk size and speed? |
|
@lukeramsden It brings the size down from 41MB to 9MB :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching out JS engine