New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple empty spaces are added above the Tabs Footer on every reload (reproducible) #342

Closed
kimheisler opened this Issue Apr 25, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@kimheisler

kimheisler commented Apr 25, 2018

Hello,
as i mentioned in the forum:
http://forum.jasonette.com/t/multiple-empty-spaces-are-added-above-the-footer-on-every-reload-reproducible/854
i found the following bug when using the Tabs Footer:

I noticed when using the Tabs Footer on every reload an empty space with the height of the footer is added above the footer. This behavior is reproducible and it is even in the Twitter-UI-Demo.

As a demonstration i captured this video using the Twitter-UI-Demo:
https://adobe.ly/2qVIqBu

I think in Xcode it has to do something with the lines around 1083 in the JasonViewController.m

CGFloat bottom_padding = 0.0;
  if (body[@"footer"] && body[@"footer"][@"tabs"]) {
      bottom_padding += self.tabBarController.tabBar.frame.size.height;
  }
  if (body[@"footer"] && body[@"footer"][@"input"]) {
      bottom_padding += self.composeBarView.frame.size.height;
  }
  self.tableView.contentInset = UIEdgeInsetsMake(self.tableView.contentInset.top, self.tableView.contentInset.left, self.tableView.contentInset.bottom+bottom_padding, self.tableView.contentInset.right);
original_bottom_inset = self.tableView.contentInset.bottom;
@gliechtenstein

This comment has been minimized.

Contributor

gliechtenstein commented Apr 29, 2018

This bug should be fixed with de863aa

Thanks for reporting! Please try it out and close the issue if you confirm that it's been fixed.

@kimheisler

This comment has been minimized.

kimheisler commented Apr 30, 2018

Thank you, it's working 👍

@kimheisler kimheisler closed this Apr 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment