New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging Action #20

Merged
merged 3 commits into from Nov 7, 2016

Conversation

Projects
None yet
2 participants
@seletz
Contributor

seletz commented Nov 7, 2016

Added very simplistic $log.{info,debug,error} actions.

Logging Action
Added very simplistic $log.{info,debug,error} actions.
@gliechtenstein

This comment has been minimized.

Contributor

gliechtenstein commented Nov 7, 2016

Looks great!

One thing, I've been using text as an attribute name when we need to pass a textual argument. Here's the most similar example $util.toast

For consistency's sake would you mind just renaming message to text and re-commit? I think that would be easier to remember..

Log Action
Renamed input option from "message" to "text" for consistency with
other actions.
@gliechtenstein

This comment has been minimized.

Contributor

gliechtenstein commented Nov 7, 2016

@seletz I just noticed UINavigationControllerDelegate https://github.com/nexiles/JASONETTE-iOS/blob/f69916bf44d8af4da96ae70540becbb6bf9000d2/app/Jasonette/JasonLogAction.h#L8 and just curious,, do we need this?

Log Action
Remove unneeded protocol.

@gliechtenstein gliechtenstein merged commit 63b6063 into Jasonette:develop Nov 7, 2016

@gliechtenstein

This comment has been minimized.

Contributor

gliechtenstein commented Nov 7, 2016

There's an additional commit to add these files to the project 2d128e1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment