Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Google Admob integration #92
This update can support both Banner and Interstitial ads. You can integrate ads with below json in
@wajahatch888 wow that was fast! Looking through the code I have a couple of questions (Please note that I'm a newbie with ads so some questions may sound clueless)
This approach would be analogous to how we use
But like I said, I'm a total newbie with ads and this really depends on the possibilities going forward, so I would appreciate your insight.
@gliechtenstein , Thanks for reviewing. Below are the replies for your concerns
1- Previously ads were not showing with full width. Full width compatibility added.
Ads are working on Portrait and Landscape mode.
Awesome. Just re-read through the code and I think the code is good to go!
That said, I did run into a critical problem that I hadn't thought of before. The problem is:
You know how Apple asks you if you have used Advertising Identifier? Due to the way Jasonette works, if we just ship it this way, everyone who uses Jasonette must sign "YES" to this question.
To tackle this problem we need to make sure that the code for the ads IS NOT included in the resulting binary by default unless specified.
There was a similar situation earlier when we implemented push notification because not everyone needs the push feature yet this caused problems when submitting--the appstore would complain that there's a code for push notification but you haven't enabled the push capability from the
How we tackled a similar problem with push notifications
The solution back then was to use
This is just one idea--theoretically we could do the same by adding another