Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to stream json data directly to another stream #585

Open
jeremydmiller opened this issue Oct 25, 2016 · 6 comments
Open

Ability to stream json data directly to another stream #585

jeremydmiller opened this issue Oct 25, 2016 · 6 comments
Labels
Milestone

Comments

@jeremydmiller
Copy link
Contributor

@jeremydmiller jeremydmiller commented Oct 25, 2016

For the case where all you want to do is get some results from the server as JSON and send it down to an HTTP response. Skip the JSON string altogether and just copy bytes from one stream to another.

@jeremydmiller jeremydmiller modified the milestones: 1.2, 1.3 Oct 26, 2016
@jeremydmiller jeremydmiller modified the milestone: 1.3 Feb 8, 2017
@jeremydmiller
Copy link
Contributor Author

@jeremydmiller jeremydmiller commented Mar 23, 2017

Think this is going to have to be in 2.0

@jeremydmiller jeremydmiller added this to the 2.0 milestone Mar 23, 2017
@jeremydmiller jeremydmiller modified the milestones: 2.0, 2.1 Jun 7, 2017
@jeremydmiller jeremydmiller modified the milestone: 2.1 Aug 11, 2017
@jeremydmiller jeremydmiller modified the milestone: 2.4.0 Nov 10, 2017
@jeremydmiller jeremydmiller added this to the 3.0 milestone Aug 31, 2018
@jeremydmiller jeremydmiller removed this from the 3.0 milestone Sep 26, 2018
@oskardudycz oskardudycz added this to the 4.0 milestone Sep 28, 2018
@oskardudycz
Copy link
Collaborator

@oskardudycz oskardudycz commented Sep 28, 2018

Cool idea. It would be nice to do it for milestone 4.0 imho.

@jeffdoolittle
Copy link
Contributor

@jeffdoolittle jeffdoolittle commented Oct 4, 2018

Curious if GraphQL is still in the works as mentioned here: https://jeremydmiller.com/2018/06/07/planning-the-next-couple-marten-releases/

Note that this blog post references #585

@Miggleness
Copy link
Contributor

@Miggleness Miggleness commented Feb 1, 2020

Has there been any thought on the API to get the streaming option? Like .Streaming() at the end of a query?

There would still be a need to convert stream to UTF8 since jsonb isn't stored in that encoding.

@jeremydmiller
Copy link
Contributor Author

@jeremydmiller jeremydmiller commented Feb 1, 2020

@Miggleness The serializer shouldn't have to get involved at all. It should be Npgsql's streaming support effectively pushing bytes directly to the HttpResponse.Body. There's gonna be some hiccups maybe if we need to strip out some serializer specific noise, but we'll have to cross that bridge when we get to it

@Miggleness
Copy link
Contributor

@Miggleness Miggleness commented Feb 2, 2020

I'll find time to play around with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants