-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addmesh #8
Conversation
Parameter.md
Outdated
- **Grid scale**-> Input ABAQUS meshes are scaled 1000 times smaller with help of this parameter. | ||
- **Plate dim**-> Dimension of the side of input geometry (square). | ||
- **Crack length**-> Length of the pre-existing crack in the body. | ||
- **Ref region height perc**-> Refinement region height percentage: Input parameter as a percentage of Plate dim. Only required in lefm cases of M_I and M_Id. This height(h) is defined as length of the area above or below crack which will be refined. So total height of refined area will be 2h. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
explain this in more detail what exactly you mean here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add a picture of the geometry in CD/DVD to be submitted. I think these points will be more clear in that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An image will definitely aid in understanding. You can also add it here. It is possible to add images in a .md file.
Parameter.md
Outdated
- **Plate dim**-> Dimension of the side of input geometry (square). | ||
- **Crack length**-> Length of the pre-existing crack in the body. | ||
- **Ref region height perc**-> Refinement region height percentage: Input parameter as a percentage of Plate dim. Only required in lefm cases of M_I and M_Id. This height(h) is defined as length of the area above or below crack which will be refined. So total height of refined area will be 2h. | ||
- **Crack tip back ref perc**-> Crack tip back refinement percentage: Input parameter as a percentage of crack length. Only required in lefm cases of M_I and M_Id. This length is defined as the length of the refined area in the back of the crack tip. This parameter ensures that crack tip is surrounded by fine mesh from every direction and that refinement doesn't start abruptly from crack tip. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
explain in detail what exactly you mean by "back of crack tip"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add a picture of the geometry in CD/DVD to be submitted. I think visual will help to understand it better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
README.md
Outdated
The mesh name nomenclature used in parameter files name is described below: | ||
1. **mesh01** -> This mesh is used for M_I and M_Id type crack in tension test and contains pre-refined mesh where crack is expected to grow with element size h = 0.001 mm (approx).(Tension_left_1.inp) | ||
2. **mesh02** -> This mesh is used for P_I type crack for tension test and contains pre-refined mesh where crack is to be prescribed and expected to grow with element size h = 0.001 mm (approx).(Tension_left_10.inp) | ||
3. **mesh03** -> This mesh is used for M_I type crack for shear test and contains pre-refined mesh where crack is expected to grow with element size h = 0.002 mm (approx).(Shear_left_2.inp) | ||
4. **mesh04** -> This mesh is used for M_I and M_Id type crack for lefm scenarios and subsequent global and local refinement will be implemented in the program giving us a element size of h = 0.001 mm(approx).(Tension_left_lefm_1.inp) | ||
5. **mesh05** -> This mesh is used for P_I type crack for lefm scenarios and contains a pre-refined mesh where crack is to be prescribed and expected to grow with element size of h = 0.001 mm(approx).(Tension_left_lefm_2.inp) | ||
6. **mesh06_01/02** -> This mesh is used for P_I type crack for tension test using method of single row of nodes as a crack and is refined appropriately with local and global refinement to get element sizes of h = 0.001 mm(**mesh06-01**)and h = 0.0007 mm (**mesh06-02**) respectively.(Tension_left_7.inp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more detail needed to make it self-understandable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please specify what information is missing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DO suggested changes
Parameter.md
Outdated
- **Tension x axis bottom**-> Boundary condition for bottom boundary in x-axis for tension test. Applicable to all cases of pre-existing crack- M_I, M_Id and P_I. | ||
- **Tension x axis top**-> Boundary condition for top boundary in x-axis for tension test. Applicable to all cases of pre-existing crack- M_I, M_Id and P_I. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
possible options?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added possible options of fixed and free.
Parameter.md
Outdated
- **Initial crack strategy**-> Pre-existing crack modeling strategy. | ||
- **Computing strategy**-> Whether we are solving Standard Numerical examples or LEFM. | ||
- **Initial crack strategy**-> Pre-existing crack modeling strategy. Possible options are **M_I**, **M_Id** and **P_I**. | ||
- **Computing strategy**-> Whether we are solving Standard Numerical examples or LEFM. Possible options are **StandardNum** and **lefm**. | ||
- **Target factor fracture toughness**-> Applicable for lefm only. Decides upto what value of K_IC should the time loop run. | ||
- **Target steps fracture toughness**-> Applicable for lefm only. Decides the number of steps in which K_I should reach value of K_IC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is confusing. Ideally we should only have K_I_total = factor*K_Ic
and the time-step size should decide how long it takes to reach there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My program doesn't take time-step size to decide the duration so this parameter is added here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but then what is the use of total time ?
README.md
Outdated
@@ -7,7 +7,7 @@ Please refer to Algorithm-1 in thesis-report in order to understand the project | |||
# Mesh file | |||
The mesh name nomenclature used in parameter files name is described below: | |||
1. **mesh01** -> This mesh is used for M_I and M_Id type crack in tension test and contains pre-refined mesh where crack is expected to grow with element size h = 0.001 mm (approx).(Tension_left_1.inp) | |||
2. **mesh02** -> This mesh is used for P_I type crack for tension test and contains pre-refined mesh where crack is to be prescribed and expected to grow with element size h = 0.001 mm (approx).(Tension_left_10.inp) | |||
2. **mesh02** -> This mesh is used for P_I type crack for tension test and contains pre-refined mesh where crack is to be prescribed as well as where the crack is expected to grow with element size h = 0.001 mm (approx).(Tension_left_10.inp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is pre-existing crack modelled?
You could also refer to figures in thesis document for explanation purposes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
README.md
Outdated
@@ -7,7 +7,7 @@ Please refer to Algorithm-1 in thesis-report in order to understand the project | |||
# Mesh file | |||
The mesh name nomenclature used in parameter files name is described below: | |||
1. **mesh01** -> This mesh is used for M_I and M_Id type crack in tension test and contains pre-refined mesh where crack is expected to grow with element size h = 0.001 mm (approx).(Tension_left_1.inp) | |||
2. **mesh02** -> This mesh is used for P_I type crack for tension test and contains pre-refined mesh where crack is to be prescribed and expected to grow with element size h = 0.001 mm (approx).(Tension_left_10.inp) | |||
2. **mesh02** -> This mesh is used for P_I type crack for tension test and contains pre-refined mesh where crack is to be prescribed as well as where the crack is expected to grow with element size h = 0.001 mm (approx).(Tension_left_10.inp) | |||
3. **mesh03** -> This mesh is used for M_I type crack for shear test and contains pre-refined mesh where crack is expected to grow with element size h = 0.002 mm (approx).(Shear_left_2.inp) | |||
4. **mesh04** -> This mesh is used for M_I and M_Id type crack for lefm scenarios and subsequent global and local refinement will be implemented in the program giving us a element size of h = 0.001 mm(approx).(Tension_left_lefm_1.inp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
specify what values are to be set for other relevant parameters to obtain the desired mesh refinement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Values for other relevant parameters are set in their corresponding parameter files of mesh04. (M_I_lefm_l-0.0075_v-0_mesh04.prm and M_Id_lefm_l-0.0075_v-0_mesh04.prm ). Specifying the other values here will create confusion as one has to explain the terms used also.
@@ -7,7 +7,7 @@ Please refer to Algorithm-1 in thesis-report in order to understand the project | |||
# Mesh file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add something like:
Meshes XX, YY ... have been generated using Abaqus while Meshes AA, BB.. have been generated using the adaptive refinement strategies of deal.ii by means of specifying the requisite parameters as described below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any meshes which are generated in Abaqus and then refiened in deal.II? if yes, the method of generation for each mesh must be described briefly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. Only mesh04 is a different type and parameters for its generation are defined in its corresponding parameter files.
Parameter.md
Outdated
- **Crack tip back ref perc**-> Crack tip back refinement percentage: Input parameter as a percentage of crack length. Only required in lefm cases of M_I and M_Id. This length is defined as the length of the refined area in the back of the crack tip. This parameter ensures that crack tip is surrounded by fine mesh from every direction and that refinement doesn't start abruptly from crack tip. | ||
- **Plate dim**-> Dimension of the side of input geometry (square) in mm (denoted as a). ![Geometry image](Geometry.jpg). | ||
- **Crack length**-> Length of the pre-existing crack in the body in mm (denoted as b). ![Geometry image](Geometry.jpg). | ||
- **Ref region height perc**-> Refinement region height percentage: Input parameter as a percentage of Plate dim. Only required in lefm cases of M_I and M_Id. This height(h) is defined as length of the area above or below crack which will be refined. So total height of refined area will be 2h. ![Geometry image](Geometry.jpg). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all images should be moved to docs folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also all .md files except README should be moved to docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All .md files (except README.md) and a image file have been moved to doc folder. The ones being shown now outside will be removed in a separate branch.
Parameter.md
Outdated
|
||
# TestCase | ||
- **Test case**-> Parameter which decides whether test being run is tension or shear. Possible options are **tension** and **shear**. | ||
- **Test case**-> Parameter which decides whether test being run is tension or shear. Possible options are **tension** and **shear**. Onlu applicable for **benchmarks** problem type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
Parameter.md
Outdated
- **Tension x axis bottom**-> Boundary condition for bottom boundary in x-axis for tension test. Possible options are **fixed** and **free**. Applicable to all cases of pre-existing crack- M_I, M_Id and P_I. | ||
- **Tension x axis top**-> Boundary condition for top boundary in x-axis for tension test. Possible options are **fixed** and **free**. Applicable to all cases of pre-existing crack- M_I, M_Id and P_I. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only applicable for benchmark problem type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
README.md
Outdated
5. **mesh05** -> This mesh is used for P_I type crack for lefm scenarios and contains a pre-refined mesh where crack is to be prescribed and expected to grow with element size of h = 0.001 mm(approx).(Tension_left_lefm_2.inp) | ||
6. **mesh06_01/02** -> This mesh is used for P_I type crack for tension test using method of single row of nodes as a crack and is refined appropriately with local and global refinement to get element sizes of h = 0.001 mm(**mesh06-01**)and h = 0.0007 mm (**mesh06-02**) respectively.(Tension_left_7.inp) | ||
6. **mesh06_01/02** -> This mesh is used for P_I type crack for **tension test** using method of single row of nodes as a crack and is refined appropriately with local and global refinement to get element sizes of h = 0.001 mm(**mesh06-01**)and h = 0.0007 mm (**mesh06-02**) respectively.(Tension_left_7.inp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what exactly is the difference between mesh05 and mesh06? please specify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mesh05 is for lefm mode I and uses method of single row of elements as a crack. And mesh06 is for tension test for benchmark problems using method of single row of nodes as a crack. I have updated the same also in their definition.
README.md
Outdated
2. **mesh02** -> This mesh is used for P_I type crack in **tension test** for benchmark problems using method of single row of elements as a crack and contains pre-refined mesh where crack is to be prescribed as well as where the crack is expected to grow with element size h = 0.001 mm (approx).(Tension_left_10.inp) | ||
3. **mesh03** -> This mesh is used for M_I type crack in **shear test** for benchmark problems and contains pre-refined mesh where crack is expected to grow with element size h = 0.002 mm (approx).(Shear_left_2.inp) | ||
4. **mesh04** -> This mesh is used for M_I and M_Id type crack for lefm mode I scenarios and subsequent global and local refinement will be implemented in the program giving us a element size of h = 0.001 mm(approx).(Tension_left_lefm_1.inp) | ||
5. **mesh05** -> This mesh is used for P_I type crack for lefm mode I scenarios using method of single row of elements as a crack and contains a pre-refined mesh where crack is to be prescribed and expected to grow with element size of h = 0.001 mm(approx).(Tension_left_lefm_2.inp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still can't see the difference between mesh05 and mesh06-01. how exactly do they differ in construction?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mesh06 uses the method of single row of nodes as a crack. (which doesn't produces the correct result! Results are with a bump!). mesh05 uses the method of single row of elements as a crack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
single row of elements gives us correct results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please highlight these phrases to improve readability
doc/Figures.md
Outdated
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove extra lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if any more changes are required in the code for submission.
@Jatandeep remove the blank lines in Figure.md |
Update in mesh and prm files