Message#getLink method.

[Joshix-1]

It is really helpful to have such a method. Some don't know how the links are composed, and for others it is helpful do just use the Javacord method instead of creating an own.

[Vampire]

Should this and the others probably return URL instead?

[Joshix-1]

I'm not sure if that's better. I would think it is more convenient to leave it as String. I don't see any use case where it would be better to have it as an URL.

[Vampire]

Well, it is an URL, that could be reason enough.
But I'll let that decision for @Bastian, I just mentioned it to be thought about. :-)

[Bastian]

I have to agree with Vampire. It is a url and thus should return a URL object.
This is also consistent with all the other methods of Javacord that return a url.

[Joshix-1]

Then I will change that :-)

[Joshix-1]

How should I handle the MalformedURLException?

[Bastian]

In other places we just return null and log a error, but this would be better:

try {
    URL url = new URL("");
} catch (MalformedURLException e) {
    throw new AssertionError("Message link is malformed", e);
}

[Vampire]

I would have also said catch and transform to AssertionError.
As we construct the URL and know it is valid, it is a programming error if a MURLE is thrown, so translating it to an AssertionError is the way to go.

[Vampire]

Also you should change the target branch of the PR to development

[Vampire]

And you should execute check task, or at least look what our CI said, as you violated the defined checkstyle rules. Please fix up your commits, so that each one results in a green build.

[Vampire]

Please rebase your branch instead of merging in development and fix up each commit so that it has a green checkmark at https://github.com/Javacord/Javacord/pull/535/commits meaning each commit individually results in a successful build.
You might even consider making one commit of them, the changes are pretty atomic alltogether I'd say. :-)

[Bastian]

Besides the method return type, this looks good to me.
Thanks! :)