Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uplas_reoffset: small bug and a few typos #371
Comments
|
Thank you for reporting. It is fixed now. I guess this bug has actually no effect because it was on Z. On XY it may have been critical. I also fixed the doc. Thanks for the corrections |
Dear lidR developers,
I think I've spotted a small bug in the code of the las_reoffset function: In line 70 the maximum Z value of the public header block is fetched with a lower-case
zinstead of an upper-case one, i.e. the code goeslas@header@PHB[["Max z"]](which returnsNULL) instead oflas@header@PHB[["Max Z"]].As far as I can tell this would only be a problem in very rare edge cases, though.
Regarding the documentation of the las_rescale and las_reoffset functions:
I think it should go
"This function modifies the header and recomputes the coordinates. Coordinates might be moved by few tenth of a millimeter or few millimeters depending on the accuracy imposed by the user."
instead of
"This function modify the header and recompute the coordinates. Coordinates might be moved by few tenth of millimeters or few millimeters depending of the accuracy imposed by the user.".
Disclaimer: I am confident in my English skills in this case but English is not my mother tongue, so please ignore anything that looks wrong to you.
Kind Regards,
Leon