Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

las_reoffset: small bug and a few typos #371

Closed
Lenostatos opened this issue Sep 8, 2020 · 1 comment
Closed

las_reoffset: small bug and a few typos #371

Lenostatos opened this issue Sep 8, 2020 · 1 comment
Assignees
Labels
Bug

Comments

@Lenostatos
Copy link

@Lenostatos Lenostatos commented Sep 8, 2020

Dear lidR developers,

I think I've spotted a small bug in the code of the las_reoffset function: In line 70 the maximum Z value of the public header block is fetched with a lower-case z instead of an upper-case one, i.e. the code goes
las@header@PHB[["Max z"]] (which returns NULL) instead of
las@header@PHB[["Max Z"]].
As far as I can tell this would only be a problem in very rare edge cases, though.

Regarding the documentation of the las_rescale and las_reoffset functions:

I think it should go
"This function modifies the header and recomputes the coordinates. Coordinates might be moved by few tenth of a millimeter or few millimeters depending on the accuracy imposed by the user."
instead of
"This function modify the header and recompute the coordinates. Coordinates might be moved by few tenth of millimeters or few millimeters depending of the accuracy imposed by the user.".

Disclaimer: I am confident in my English skills in this case but English is not my mother tongue, so please ignore anything that looks wrong to you.

Kind Regards,
Leon

@Jean-Romain Jean-Romain self-assigned this Sep 8, 2020
@Jean-Romain Jean-Romain added the Bug label Sep 8, 2020
@Jean-Romain
Copy link
Owner

@Jean-Romain Jean-Romain commented Sep 8, 2020

Thank you for reporting. It is fixed now. I guess this bug has actually no effect because it was on Z. On XY it may have been critical. I also fixed the doc. Thanks for the corrections

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.