Skip to content

/ rlas

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing a check in ReturnNumbers for las version 1.4-6 #45

Merged
merged 1 commit into from Feb 13, 2020
Merged

Fixing a check in ReturnNumbers for las version 1.4-6 #45

merged 1 commit into from Feb 13, 2020

Conversation

@mccarthyryanc
Copy link

@mccarthyryanc mccarthyryanc commented Feb 13, 2020

is_extended correctly returns true for version 1.4-6 files. But the nbits gets assigned 3L instead of 4L. Simple swap to get the correct value set.
Ryan McCarthy
Fixing a check in ReturnNumbers for las version 1.4-6. ReturnNumber i…
Loading status checks…
b1f475e 
…s 4 bits not 3.
@Jean-Romain Jean-Romain merged commit 0129e4c into Jean-Romain:master Feb 13, 2020
2 of 3 checks passed
2 of 3 checks passed
codecov/patch 0% of diff hit (target 72.78%)
Details
Travis CI - Pull Request Build Passed
Details
codecov/project 72.78% remains the same compared to 9ffd39f
Details
@Jean-Romain
Copy link
Owner

@Jean-Romain Jean-Romain commented Feb 13, 2020

Thank you, nice catch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@mccarthyryanc @Jean-Romain
You can’t perform that action at this time.