New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Creatable] Handle null children prop gracefully #1430

Merged
merged 1 commit into from Jan 31, 2017

Conversation

Projects
None yet
3 participants
@jscinoz
Contributor

jscinoz commented Dec 14, 2016

Previously Creatable used ES6 destructuring default values to set children to defaultChildren.

If a null children prop is passed, the null value will be used, rather than the default value, as Babel compiles destructuring defaults to value === undefined ? defaultValue : value. This will result in an exception when children is invoked as a function a few lines later.

This patch simply amends Creatable's render() method to use defaultChildren if children is any kind of falsey value.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 14, 2016

Coverage Status

Coverage increased (+0.01%) to 92.318% when pulling 1ec2707 on AvokaTech:master into ef3a468 on JedWatson:master.

coveralls commented Dec 14, 2016

Coverage Status

Coverage increased (+0.01%) to 92.318% when pulling 1ec2707 on AvokaTech:master into ef3a468 on JedWatson:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 14, 2016

Coverage Status

Coverage increased (+0.01%) to 92.318% when pulling a40ca88 on AvokaTech:master into ef3a468 on JedWatson:master.

coveralls commented Dec 14, 2016

Coverage Status

Coverage increased (+0.01%) to 92.318% when pulling a40ca88 on AvokaTech:master into ef3a468 on JedWatson:master.

@JedWatson

This comment has been minimized.

Show comment
Hide comment
@JedWatson
Owner

JedWatson commented Jan 31, 2017

Thanks @jscinoz

@JedWatson JedWatson merged commit c6fa633 into JedWatson:master Jan 31, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 92.318%
Details

restlessbit added a commit to underdogio/react-select that referenced this pull request May 5, 2017

Don't modify original user input when ignoreCase prop is true
Squashed commit of the following:

commit 4127a91
Author: Mario Pabon <me@mariopabon.com>
Date:   Fri May 5 15:40:34 2017 -0400

    Fix ignore case logic

commit 9de3d21
Author: Mario Pabon <me@mariopabon.com>
Date:   Fri May 5 15:07:59 2017 -0400

    Create a new build

commit 789312f
Author: Mario Pabon <me@mariopabon.com>
Date:   Fri May 5 15:03:57 2017 -0400

    Add missing prop-types dependency

commit 9cee911
Author: Mario Pabon <me@mariopabon.com>
Date:   Fri May 5 15:02:12 2017 -0400

    Fix ignore case logic

commit bf14e59
Author: Mario Pabon <me@mariopabon.com>
Date:   Fri May 5 14:57:34 2017 -0400

    Add missing dependency

commit d73c4c4
Merge: 6a92c3c a0e5855
Author: Mario Pabon <me@mariopabon.com>
Date:   Fri May 5 14:54:55 2017 -0400

    Merge remote-tracking branch 'source/master' into dev/fix.ignore.case

commit 6a92c3c
Author: Mario Pabon <me@mariopabon.com>
Date:   Fri May 5 14:41:39 2017 -0400

    Don't lowercase user's input on input change

commit a0e5855
Merge: 80943b4 ba7dc9f
Author: Jed Watson <jed.watson@me.com>
Date:   Thu Mar 30 23:04:40 2017 +1100

    Merge pull request JedWatson#1571 from interface48/aria-describedby

    Adding support for aria-describedby attribute

commit 80943b4
Merge: 5f7c4c6 c3e9f46
Author: Jed Watson <jed.watson@me.com>
Date:   Thu Mar 30 22:57:35 2017 +1100

    Merge pull request JedWatson#1569 from the-spyke/fix-1437-creatable-no-focus

    Fix missing .focus() method in Creatable (JedWatson#1437)

commit c3e9f46
Merge: 5513893 5f7c4c6
Author: Anton Alexandrenok <antonalexandrenok@gmail.com>
Date:   Thu Mar 30 09:47:15 2017 +0300

    Merge branch 'master' into fix-1437-creatable-no-focus

commit 5f7c4c6
Merge: 93c3009 9f82da2
Author: Jed Watson <jed.watson@me.com>
Date:   Thu Mar 30 10:49:35 2017 +1100

    Merge pull request JedWatson#1621 from radixhound/fix_readme_tables

    Fix readme tables

commit 9f82da2
Author: Christopher Dwan <chris@radixhound.com>
Date:   Thu Mar 23 09:25:40 2017 -0700

    Replace tabs in README with two spaces

commit 14f199c
Author: Christopher Dwan <chris@radixhound.com>
Date:   Thu Mar 23 09:24:21 2017 -0700

    Make table formatting consistent

    - remove attempts to align the tables and just use one space around pipes
    - add pipes to the front and end of each line

commit 93c3009
Author: Jed Watson <jed.watson@me.com>
Date:   Thu Mar 16 22:43:36 2017 -0700

    Adding multi prop to Async component, resolves ESLint warning

commit bb75169
Merge: 2249f26 a0972e3
Author: Jed Watson <jed.watson@me.com>
Date:   Thu Mar 16 22:24:31 2017 -0700

    Merge pull request JedWatson#1512 from rndm2/master

    Fixed bug. No more comparing objects in getFocusableOptionIndex

commit 5513893
Author: Anton Alexandrenok <antonalexandrenok@gmail.com>
Date:   Tue Mar 14 12:03:35 2017 +0300

    Added .focus() to AsyncCreatable

commit ba7dc9f
Author: Eric Lee <eric.lee@interface48.com>
Date:   Tue Feb 21 14:53:32 2017 -0800

    Sort aria-describedby propTypes alphabetically

commit af0f77f
Author: Eric Lee <eric.lee@interface48.com>
Date:   Tue Feb 21 14:30:57 2017 -0800

    Add aria-describedby support

commit cce53da
Author: Anton Alexandrenok <antonalexandrenok@gmail.com>
Date:   Tue Feb 21 10:12:53 2017 +0300

    Added .focus() instance method

commit 2249f26
Merge: 5aef30d 514a426
Author: Jed Watson <jed.watson@me.com>
Date:   Sun Feb 19 20:38:04 2017 +1100

    Merge pull request JedWatson#1564 from mberneti/master

    document the undocumented 'loadingPlaceholder' property

commit 514a426
Author: mohammaadreza berneti <mberneti@live.com>
Date:   Sun Feb 19 11:17:33 2017 +0330

    document the undocumented 'loadingPlaceholder' property

commit 5aef30d
Merge: 535fd8a ffa1f2d
Author: Jed Watson <jed.watson@me.com>
Date:   Fri Feb 10 12:01:23 2017 +1100

    Merge pull request JedWatson#1527 from jonashaag/patch-1

    Fix openOnFocus

commit ffa1f2d
Author: Jonas Haag <jonas@lophus.org>
Date:   Fri Feb 3 11:47:49 2017 +0100

    Fix openOnFocus

commit ad0724d
Author: Jonas Haag <jonas@lophus.org>
Date:   Fri Feb 3 11:33:30 2017 +0100

    Fix openOnFocus

commit 535fd8a
Author: Jed Watson <jed.watson@me.com>
Date:   Thu Feb 2 12:12:45 2017 +1100

    Adding note about JedWatson#1226, ref JedWatson#1522

commit 81ae889
Merge: 63a59dc 05de92f
Author: Jed Watson <jed.watson@me.com>
Date:   Thu Feb 2 12:06:34 2017 +1100

    Merge pull request JedWatson#1522 from Noviny/update-changelog

    Update changelog

commit 05de92f
Author: noviny <novinyarts@gmail.com>
Date:   Wed Feb 1 11:58:18 2017 +1100

    Update changelog

commit a0972e3
Author: Konstantyn Maryanovsky <konstantyn.maryanovsky@nextiva.com>
Date:   Tue Jan 31 20:17:17 2017 +0200

    Fixed bug. Looking for focusedOption can return incorrect value in case when focusedOption not equal to any element of array, IE compatible

commit 63a59dc
Author: Jed Watson <jed.watson@me.com>
Date:   Wed Feb 1 01:54:53 2017 +1100

    v1.0.0-rc.3

commit 732ba55
Author: Jed Watson <jed.watson@me.com>
Date:   Wed Feb 1 01:54:24 2017 +1100

    Updating build

commit ef894a3
Author: Jed Watson <jed.watson@me.com>
Date:   Wed Feb 1 01:53:27 2017 +1100

    Fixing an error thrown in the CustomRender example

commit 881873c
Author: Jed Watson <jed.watson@me.com>
Date:   Wed Feb 1 01:50:36 2017 +1100

    Cleaning up boolean value example

commit cab0b72
Author: Jed Watson <jed.watson@me.com>
Date:   Wed Feb 1 01:48:21 2017 +1100

    Positioning fix for the arrow when the menu is open

commit fbeb376
Author: Jed Watson <jed.watson@me.com>
Date:   Wed Feb 1 01:39:17 2017 +1100

    Fixing and documenting focus behaviour for multi-select when adding options

commit 2821f0a
Author: Jed Watson <jed.watson@me.com>
Date:   Wed Feb 1 01:30:54 2017 +1100

    Cleaning up order of focusing

    The calls to setState should be batched, but this protects against an
    edge-case where they may not be

commit bba9077
Author: Jed Watson <jed.watson@me.com>
Date:   Wed Feb 1 01:28:56 2017 +1100

    Fixing a tab where there should be a space

commit 912cbb8
Merge: b6a0636 338c0ad
Author: Jed Watson <jed.watson@me.com>
Date:   Wed Feb 1 01:29:24 2017 +1100

    Merge pull request JedWatson#1406 from nraynaud/master

    try to focus the next available option after a selection.

commit b6a0636
Merge: 9bebcd0 ba2bd5e
Author: Jed Watson <jed.watson@me.com>
Date:   Wed Feb 1 01:23:00 2017 +1100

    Merge pull request JedWatson#1331 from mcls/master

    Re-added the focus() method on Select.Async

commit 9bebcd0
Merge: 00418b3 080670c
Author: Jed Watson <jed.watson@me.com>
Date:   Wed Feb 1 01:21:18 2017 +1100

    Merge pull request JedWatson#1408 from khankuan/patch-1

    Provide `isOpen` to arrowRenderer

commit 00418b3
Merge: dbbd63b 10cd5b2
Author: Jed Watson <jed.watson@me.com>
Date:   Wed Feb 1 01:18:48 2017 +1100

    Merge pull request JedWatson#1420 from tnrich/patch-1

    tiny update to readme fixing noResultsText info

commit dbbd63b
Author: Jed Watson <jed.watson@me.com>
Date:   Wed Feb 1 01:00:03 2017 +1100

    Clarifying comment for defaultChildren

commit c6fa633
Merge: 7d4b8f0 a40ca88
Author: Jed Watson <jed.watson@me.com>
Date:   Wed Feb 1 00:56:54 2017 +1100

    Merge pull request JedWatson#1430 from AvokaTech/master

    [Creatable] Handle null children prop gracefully

commit 7d4b8f0
Merge: 06766b4 f11520a
Author: Jed Watson <jed.watson@me.com>
Date:   Wed Feb 1 00:46:17 2017 +1100

    Merge pull request JedWatson#1448 from thezanke/master

    Fixes JedWatson#1447 - Uncaught TypeError

commit 06766b4
Author: Jed Watson <jed.watson@me.com>
Date:   Wed Feb 1 00:44:22 2017 +1100

    Documenting custom classNames for Select and options, closes JedWatson#1452

commit d17c535
Author: Jed Watson <jed.watson@me.com>
Date:   Wed Feb 1 00:41:49 2017 +1100

    Removing an extra space

commit 9a677c2
Author: Jed Watson <jed.watson@me.com>
Date:   Wed Feb 1 00:24:43 2017 +1100

    Indentation fixes

commit 19a6acc
Merge: 5c2f71f 13444bd
Author: Jed Watson <jed.watson@me.com>
Date:   Wed Feb 1 00:13:16 2017 +1100

    Merge pull request JedWatson#1451 from dmatteo/patch-1

    Document the undocumented `ignoreAccents` property

commit 5c2f71f
Merge: 2ef6753 bbc585d
Author: Jed Watson <jed.watson@me.com>
Date:   Wed Feb 1 00:12:31 2017 +1100

    Merge pull request JedWatson#1478 from conorhastings/clear-renderer

    allow rendering a custom clear component

commit 2ef6753
Author: Jed Watson <jed.watson@me.com>
Date:   Wed Feb 1 00:09:07 2017 +1100

    Ignoring yarn.lock

    May not be desirable in the long term but adding it for now to simplify
    things

commit 350354c
Merge: ca217b9 3aee31f
Author: Jed Watson <jed.watson@me.com>
Date:   Wed Feb 1 00:06:13 2017 +1100

    Merge pull request JedWatson#1496 from ivanzusko/patch-1

    Fixes for code style consistency

commit ca217b9
Author: Jed Watson <jed.watson@me.com>
Date:   Wed Feb 1 00:05:37 2017 +1100

    Porting fix from JedWatson#1500 to scss stylesheet

commit d0d2737
Merge: d1feb1d d316a05
Author: Jed Watson <jed.watson@me.com>
Date:   Wed Feb 1 00:04:56 2017 +1100

    Merge pull request JedWatson#1500 from tlconnor/fixArrowFlip

    fix arrow flip

commit d1feb1d
Merge: ef3a468 4179217
Author: Jed Watson <jed.watson@me.com>
Date:   Tue Jan 31 23:59:06 2017 +1100

    Merge pull request JedWatson#1508 from VanCoding/onchange-fix

    fixed exception when clearing an Async field that is not set to multi

commit 2d209ad
Author: Konstantyn Maryanovsky <konstantyn.maryanovsky@nextiva.com>
Date:   Mon Jan 30 13:36:43 2017 +0200

    Fixed bug. Looking for focusedOption can return incorrect value in case when focusedOption not equal to any element of array

commit 4179217
Author: Patrik Stutz <patrik.stutz@gmail.com>
Date:   Fri Jan 27 15:57:29 2017 +0100

    fixed exception when clearing an Async field that is not set to multi

commit d316a05
Author: Tim Connor <tim.connor@appfolio.com>
Date:   Mon Jan 23 13:50:53 2017 -0800

    fix arrow flip

commit 3aee31f
Author: Ivan Zusko <IvanZusko@ecenglish.com>
Date:   Sun Jan 22 00:56:45 2017 +0200

    Fixes for code style consistency

commit bbc585d
Author: conorhastings <conor@socialtables.com>
Date:   Wed Jan 11 22:53:07 2017 -0500

    allow rendering a custom clear component

commit 13444bd
Author: Domenico Matteo <matteo.domenico@gmail.com>
Date:   Tue Dec 27 16:41:18 2016 -0500

    Document the undocumented `ignoreAccents` property

commit f11520a
Author: Alex Howard <thezanke@gmail.com>
Date:   Wed Dec 21 19:11:20 2016 -0500

    Wrapped or clause (ternary) in parens

commit 7ef1013
Author: Alex Howard <thezanke@gmail.com>
Date:   Wed Dec 21 18:58:06 2016 -0500

    Fixes JedWatson#1447 - Uncaught TypeError

commit a40ca88
Author: Jack Coulter <jscinoz@jscinoz.so>
Date:   Wed Dec 14 15:35:02 2016 +1100

    fix(Creatable): Handle null "children" prop gracefully

commit 10cd5b2
Author: Thomas Rich <tnrich@teselagen.com>
Date:   Wed Dec 7 19:06:55 2016 -0800

    updating readme

    readme now reflect fact that noResultsText can be a string or a react component

commit 080670c
Author: Kuan <khankuan@gmail.com>
Date:   Sun Dec 4 19:59:06 2016 -0800

    Update README.md

commit 88e3395
Author: Kuan <khankuan@gmail.com>
Date:   Sun Dec 4 19:57:54 2016 -0800

    Update Select.js

commit 338c0ad
Author: Nicolas Raynaud <github@nraynaud.com>
Date:   Thu Dec 1 00:13:57 2016 +0100

    try to focus the next available option after a selection.

commit ef3a468
Merge: a97d5fd df99444
Author: Jed Watson <jed.watson@me.com>
Date:   Fri Nov 18 23:43:42 2016 +1100

    Merge pull request JedWatson#1367 from quizlet/aw-input-renderer-props

    Pass inputProps to inputRenderer

commit a97d5fd
Merge: da2f222 cddee25
Author: Jed Watson <jed.watson@me.com>
Date:   Fri Nov 18 23:42:46 2016 +1100

    Merge pull request JedWatson#1374 from hull/master

    fix AsyncCreatable options parsing

commit cddee25
Author: Romain Dardour <romain@hull.io>
Date:   Fri Nov 18 12:37:49 2016 +0100

    fix AsyncCreatable options parsing

    fixes JedWatson#1279

commit da2f222
Merge: ad337ee ab82015
Author: Brian Vaughn <brian.david.vaughn@gmail.com>
Date:   Thu Nov 17 17:04:48 2016 -0800

    Merge pull request JedWatson#1373 from JedWatson/react-virtualized-select-issue-33

    Fix small bug in Creatable

commit ab82015
Author: Brian Vaughn <bvaughn@fb.com>
Date:   Thu Nov 17 17:00:03 2016 -0800

    Select component passes its :menuRenderer duplicate :onSelect and :selectValue values (not sure why). Creatable only override :onSelect (whoops). This caused a bug downstream in react-virtualized-select. That bug has been fixed, but in order to prevent further confusion, this PR overrides both properties.

commit df99444
Author: Alec Winograd <alec@quizlet.com>
Date:   Mon Nov 14 10:42:31 2016 -0800

    Add tests for inputRenderer

commit 6fcc966
Author: Alec Winograd <alec@quizlet.com>
Date:   Fri Nov 11 13:43:53 2016 -0800

    Pass inputProps to inputRenderer

commit ad337ee
Merge: 603bfdd d46f960
Author: Jed Watson <jed.watson@me.com>
Date:   Fri Nov 11 22:37:59 2016 +1100

    Merge pull request JedWatson#1364 from leesiongchan/extend-creatable

    Add onNewOptionClick handler

commit 603bfdd
Merge: bd5e52e a91f539
Author: Jed Watson <jed.watson@me.com>
Date:   Fri Nov 11 22:35:21 2016 +1100

    Merge pull request JedWatson#1363 from leesiongchan/fix-creatable

    Fix onInputChange lost

commit d46f960
Author: Chan Lee Siong <ahlee2326@me.com>
Date:   Fri Nov 11 12:29:51 2016 +0800

    Add onNewOptionClick handler

    This is useful when we want to customize the click action of the new option instead of creating the option immediately.

commit a91f539
Author: Chan Lee Siong <ahlee2326@me.com>
Date:   Fri Nov 11 11:51:48 2016 +0800

    Fix onInputChange lost

commit bd5e52e
Merge: 77e6cc1 0991ab0
Author: Daniel Cousens <dcousens@users.noreply.github.com>
Date:   Fri Nov 11 00:18:15 2016 +1100

    Merge pull request JedWatson#1358 from kamronbatman/patch-1

    [Fix] Fixes spacing

commit 0991ab0
Author: Kamron Batman <kamronbatman@users.noreply.github.com>
Date:   Tue Nov 8 15:27:15 2016 -0800

    [Fix] Fixes spacing

    Fixes spacing

commit 77e6cc1
Merge: 9dd1d27 0465ea9
Author: Jed Watson <jed.watson@me.com>
Date:   Fri Nov 4 20:53:50 2016 +1100

    Merge pull request JedWatson#1347 from forum-is/master

    Delete key removes an item when there is no input

commit 0465ea9
Author: Sebastian Uecker <sebastian.uecker@forum-is.de>
Date:   Thu Nov 3 11:28:22 2016 +0100

    Added README entry for deleteRemoves prop

commit a1e0751
Author: Sebastian Uecker <sebastian.uecker@forum-is.de>
Date:   Thu Nov 3 11:11:17 2016 +0100

    Fixed comment indent

commit 1d9b8a0
Author: Sebastian Uecker <sebastian.uecker@forum-is.de>
Date:   Thu Nov 3 11:09:12 2016 +0100

    Delete key removes an item when there is no input

commit 9dd1d27
Merge: 3ce64c1 1c88892
Author: Brian Vaughn <brian.david.vaughn@gmail.com>
Date:   Sun Oct 30 09:41:50 2016 -0700

    Merge pull request JedWatson#1337 from mayerwin/patch-1

    Mention way to implement allowCreate functionality with Creatable

commit 1c88892
Author: mayerwin <mayerwin@users.noreply.github.com>
Date:   Mon Oct 31 00:25:26 2016 +0800

    Mention way to implement allowCreate functionality with Creatable

commit 3ce64c1
Merge: a8f4118 6535445
Author: Jed Watson <jed.watson@me.com>
Date:   Sun Oct 30 23:07:14 2016 +1100

    Merge pull request JedWatson#1334 from kennynaoh/cdnjs-badge

    Add CDNJS version badge in readme

commit 6535445
Author: naoh <naoh.cs03g@nctu.edu.tw>
Date:   Sat Oct 29 22:43:21 2016 +0800

    Add CDNJS version badge in readme

    This will add the badge to show its version on CDNJS and also link to its page on CDNJS!

commit ba2bd5e
Author: Maarten Claes <maartencls@gmail.com>
Date:   Thu Oct 27 13:38:37 2016 +0200

    Re-added the focus() method on Select.Async

commit dfe4119
Author: Maarten Claes <maartencls@gmail.com>
Date:   Thu Oct 27 13:30:01 2016 +0200

    Test the focus() method on Select

commit a8f4118
Merge: b4a087e 4ba7bb2
Author: Brian Vaughn <bvaughn@fb.com>
Date:   Fri Oct 21 09:22:22 2016 -0400

    Merge branch 'TheSharpieOne-fix/remove-shared-cache'

commit 4ba7bb2
Author: Brian Vaughn <bvaughn@fb.com>
Date:   Fri Oct 21 09:21:46 2016 -0400

    Refactored props/cache setting slightly

commit 426e282
Author: Brian Vaughn <bvaughn@fb.com>
Date:   Fri Oct 21 09:17:31 2016 -0400

    Fixed linting issues

commit a13246b
Merge: b4a087e ddd1fbc
Author: Brian Vaughn <bvaughn@fb.com>
Date:   Fri Oct 21 09:14:00 2016 -0400

    Merge branch 'fix/remove-shared-cache' of https://github.com/TheSharpieOne/react-select into TheSharpieOne-fix/remove-shared-cache

commit b4a087e
Merge: 4487ca7 84c2cc9
Author: Jed Watson <jed.watson@me.com>
Date:   Sat Oct 15 23:55:53 2016 +1100

    Merge pull request JedWatson#1255 from rockingskier/master

    Fix typo in <Creatable /> README.md documentation

commit 4487ca7
Merge: 47ff3a8 6b16a24
Author: Jed Watson <jed.watson@me.com>
Date:   Thu Oct 13 12:46:24 2016 +1100

    Merge pull request JedWatson#1300 from DanielHeath/fix-firefox-alignment

    Fix issues JedWatson#1272 and JedWatson#1287

commit 47ff3a8
Merge: cf0429b a7782b3
Author: Jed Watson <jed.watson@me.com>
Date:   Wed Oct 12 23:36:30 2016 +1100

    Merge pull request JedWatson#1289 from DanielHeath/clear-async-after-selection

    Clear Async options after making a selection

commit 6b16a24
Author: Daniel Heath <daniel@heath.cc>
Date:   Wed Oct 12 09:11:17 2016 +1100

    Fix issues JedWatson#1272 and JedWatson#1287

commit a7782b3
Author: Daniel Heath <daniel@heath.cc>
Date:   Tue Oct 4 13:15:23 2016 +1100

    Clear Async options after making a selection

    Currently, when you make a selection from an async
    dropdown, it keeps the list open but clears the input.

    This looks inconsistent and doesn't match the common UX
    for async search (looking up an item from a long list).

commit cf0429b
Merge: 75f3e90 45be8b4
Author: Jed Watson <jed.watson@me.com>
Date:   Tue Oct 11 22:45:29 2016 +1100

    Merge pull request JedWatson#1292 from DanielHeath/opt-out-of-clearing-options

    Only remove options if a loading placeholder is available

commit 75f3e90
Merge: 2c1cc8e 37613de
Author: Jed Watson <jed.watson@me.com>
Date:   Tue Oct 11 22:44:46 2016 +1100

    Merge pull request JedWatson#1293 from DanielHeath/add-async-no-results-text

    Allow users to specify noResultsText

commit 2c1cc8e
Merge: 7b53119 dbf6531
Author: Jed Watson <jed.watson@me.com>
Date:   Tue Oct 11 22:43:44 2016 +1100

    Merge pull request JedWatson#1290 from DanielHeath/prevent-merging-built-files

    Tell git not to merge built files

commit 7b53119
Merge: c40fea0 ecbed92
Author: Jed Watson <jed.watson@me.com>
Date:   Tue Oct 11 22:43:07 2016 +1100

    Merge pull request JedWatson#1291 from DanielHeath/trailing-whitespace

    Whitespace

commit 37613de
Author: Daniel Heath <daniel@heath.cc>
Date:   Mon Oct 10 10:50:42 2016 +1100

    Allow users to specify noResultsText

    Currently if there are no search results the message displayed
    is the same one used when a user hasn't started typing.

    This change enables users of Async to provide different messaging when
    a user has not started typing vs when no records matched a search.

commit 45be8b4
Author: Daniel Heath <daniel@heath.cc>
Date:   Thu Oct 6 16:49:01 2016 +1100

    Only remove options if a loading placeholder is available

    Currently, when `isLoading` is set to true, the options array
    is set to an empty array and we show the loading placeholder instead.

    Our app has an async service which responds in a couple of ms,
    resulting in the autocomplete list flickering in and out of existence
    as you type.

    This change allows users to opt out of the 'clear options while loading'
    behavior by not providing a loading placeholder.

commit ecbed92
Author: Daniel Heath <daniel@heath.cc>
Date:   Fri Oct 7 11:51:33 2016 +1100

    Whitespace

commit dbf6531
Author: Daniel Heath <daniel@heath.cc>
Date:   Thu Oct 6 17:19:30 2016 +1100

    Tell git not to merge built files

commit c40fea0
Merge: 4b8ec14 9709ae8
Author: Jed Watson <jed.watson@me.com>
Date:   Sat Oct 8 23:02:47 2016 +1100

    Merge pull request JedWatson#1288 from raianand/patch-1

    Fixed incorrect prop(onCloseResetsInput) in Readme

commit 9709ae8
Author: Abhishek Anand <abhishek@housing.com>
Date:   Sat Oct 8 15:47:35 2016 +0530

    Fixed incorrect prop(onCloseResetsInput) in Readme

commit 4b8ec14
Merge: e99ab1f e65b073
Author: Jed Watson <jed.watson@me.com>
Date:   Wed Oct 5 23:52:32 2016 +1100

    Merge pull request JedWatson#1281 from jtulk/patch-1

    Documentation to backspaceToRemoveMessage Property

commit e99ab1f
Merge: b3db918 ac6cb94
Author: Jed Watson <jed.watson@me.com>
Date:   Wed Oct 5 23:52:16 2016 +1100

    Merge pull request JedWatson#1257 from jooj123/patch/add-back-on-input-change

    Add back onInputChange

commit e65b073
Author: Justin Tulk <justin@79studios.com>
Date:   Tue Oct 4 13:10:47 2016 -1000

    Documentation to backspaceToRemoveMessage Property

    I don't see a better place to enable/disable this function, so adding some detail about how to clear this functionality if not wanted

commit b3db918
Merge: 0b36224 f9039c7
Author: Jed Watson <jed.watson@me.com>
Date:   Sat Oct 1 23:54:06 2016 +1000

    Merge pull request JedWatson#1265 from strayiker/master

    IE8 compatibility fixes

commit f9039c7
Author: Kirill Mesnyankin <mesk@1c.ru>
Date:   Fri Sep 30 12:03:51 2016 +0300

    Remove unit (px) from minWidth attribute

commit 6c5c828
Author: Kirill Mesnyankin <mesk@1c.ru>
Date:   Fri Sep 30 11:19:37 2016 +0300

    Use attachEvent/detachEvent for IE8 compability

commit 0b36224
Merge: 962f138 2e37a5d
Author: Jed Watson <jed.watson@me.com>
Date:   Thu Sep 29 22:30:18 2016 +1000

    Merge pull request JedWatson#1260 from DanielHeath/patch-1

    Allow react nodes to be passed as loadingPlaceholder

commit 2e37a5d
Author: Daniel Heath <daniel@heath.cc>
Date:   Thu Sep 29 14:48:40 2016 +1000

    Allow react nodes to be passed as loadingPlaceholder

    Everywhere we use loadingPlaceholder already supports `node` or `string`,
    so no other changes should be required if I'm reading correctly.

commit ac6cb94
Author: Martin Jujou <martin.jujou@domain.com.au>
Date:   Wed Sep 28 18:37:53 2016 +1000

    Add back onInputChange

commit 84c2cc9
Author: Ben <rockingskier@gmail.com>
Date:   Tue Sep 27 23:10:27 2016 +0100

    Fix typo in README.md

commit 962f138
Merge: 3b7dad8 d2ff4a9
Author: Jed Watson <jed.watson@me.com>
Date:   Sun Sep 25 20:51:43 2016 +1000

    Merge pull request JedWatson#1248 from IvanLeonenko/creatable-input-keys

    Fix for Creatable doesn't allow input key down handling. Issue JedWatson#1247

commit 3b7dad8
Merge: b4a3fd1 d5f2ce2
Author: Jed Watson <jed.watson@me.com>
Date:   Sun Sep 25 20:50:01 2016 +1000

    Merge pull request JedWatson#1249 from jooj123/patch/add-ref

    Adding back ref that was removed in rc2

commit d5f2ce2
Author: Martin Jujou <mjujou@gmail.com>
Date:   Sat Sep 24 18:37:11 2016 +1000

    Adding back ref that was removed in rc2

commit d2ff4a9
Author: Ivan Leonenko <ivan.leonenko@indg.com>
Date:   Fri Sep 23 11:36:49 2016 +0200

    Add unit test for fix - Creatable doesn't allow input key down handling. JedWatson#1247

commit 290aa15
Author: Ivan Leonenko <ivan.leonenko@indg.com>
Date:   Fri Sep 23 11:00:05 2016 +0200

    Fix for Creatable doesn't allow input key down handling. Issue JedWatson#1247

commit ddd1fbc
Author: Evan Sharp <evan.sharp@availity.com>
Date:   Thu Sep 22 11:28:31 2016 -0400

    fix(async): create new cache object for each instance by default

    fix JedWatson#1236
    Previously, the same object was being used by for async cache by
    default when no cache was passed to the component. This same object
    was used for every instance.
    Now, an object is used to determine if the default is being used
    and will create a new object for each instance in which no prop
    was passed.

Fix ignore case logic

Create a new build

Add missing prop-types dependency

Fix ignore case logic

Add missing dependency

Merge remote-tracking branch 'source/master' into dev/fix.ignore.case

Don't lowercase user's input on input change

Merge pull request JedWatson#1571 from interface48/aria-describedby

Merge pull request JedWatson#1569 from the-spyke/fix-1437-creatable-no-focus

Merge branch 'master' into fix-1437-creatable-no-focus

Merge pull request JedWatson#1621 from radixhound/fix_readme_tables

Replace tabs in README with two spaces

Make table formatting consistent

Adding multi prop to Async component, resolves ESLint warning

Merge pull request JedWatson#1512 from rndm2/master

Added .focus() to AsyncCreatable

Sort aria-describedby propTypes alphabetically

Add aria-describedby support

Added .focus() instance method

Merge pull request JedWatson#1564 from mberneti/master

document the undocumented 'loadingPlaceholder' property

Merge pull request JedWatson#1527 from jonashaag/patch-1

Fix openOnFocus

Fix openOnFocus

Adding note about JedWatson#1226, ref JedWatson#1522

Merge pull request JedWatson#1522 from Noviny/update-changelog

Update changelog

Fixed bug. Looking for focusedOption can return incorrect value in case when focusedOption not equal to any element of array, IE compatible

v1.0.0-rc.3

Updating build

Fixing an error thrown in the CustomRender example

Cleaning up boolean value example

Positioning fix for the arrow when the menu is open

Fixing and documenting focus behaviour for multi-select when adding options

Cleaning up order of focusing

Fixing a tab where there should be a space

Merge pull request JedWatson#1406 from nraynaud/master

Merge pull request JedWatson#1331 from mcls/master

Merge pull request JedWatson#1408 from khankuan/patch-1

Merge pull request JedWatson#1420 from tnrich/patch-1

Clarifying comment for defaultChildren

Merge pull request JedWatson#1430 from AvokaTech/master

Merge pull request JedWatson#1448 from thezanke/master

Documenting custom classNames for Select and options, closes JedWatson#1452

Removing an extra space

Indentation fixes

Merge pull request JedWatson#1451 from dmatteo/patch-1

Merge pull request JedWatson#1478 from conorhastings/clear-renderer

Ignoring yarn.lock

Merge pull request JedWatson#1496 from ivanzusko/patch-1

Porting fix from JedWatson#1500 to scss stylesheet

Merge pull request JedWatson#1500 from tlconnor/fixArrowFlip

Merge pull request JedWatson#1508 from VanCoding/onchange-fix

Fixed bug. Looking for focusedOption can return incorrect value in case when focusedOption not equal to any element of array

fixed exception when clearing an Async field that is not set to multi

fix arrow flip

Fixes for code style consistency

allow rendering a custom clear component

Document the undocumented `ignoreAccents` property

Wrapped or clause (ternary) in parens

Fixes JedWatson#1447 - Uncaught TypeError

fix(Creatable): Handle null "children" prop gracefully

updating readme

Update README.md

Update Select.js

try to focus the next available option after a selection.

Merge pull request JedWatson#1367 from quizlet/aw-input-renderer-props

Merge pull request JedWatson#1374 from hull/master

fix AsyncCreatable options parsing

Merge pull request JedWatson#1373 from JedWatson/react-virtualized-select-issue-33

Select component passes its :menuRenderer duplicate :onSelect and :selectValue values (not sure why). Creatable only override :onSelect (whoops). This caused a bug downstream in react-virtualized-select. That bug has been fixed, but in order to prevent further confusion, this PR overrides both properties.

Add tests for inputRenderer

Pass inputProps to inputRenderer

Merge pull request JedWatson#1364 from leesiongchan/extend-creatable

Merge pull request JedWatson#1363 from leesiongchan/fix-creatable

Add onNewOptionClick handler

Fix onInputChange lost

Merge pull request JedWatson#1358 from kamronbatman/patch-1

[Fix] Fixes spacing

Merge pull request JedWatson#1347 from forum-is/master

Added README entry for deleteRemoves prop

Fixed comment indent

Delete key removes an item when there is no input

Merge pull request JedWatson#1337 from mayerwin/patch-1

Mention way to implement allowCreate functionality with Creatable

Merge pull request JedWatson#1334 from kennynaoh/cdnjs-badge

Add CDNJS version badge in readme

Re-added the focus() method on Select.Async

Test the focus() method on Select

Merge branch 'TheSharpieOne-fix/remove-shared-cache'

Refactored props/cache setting slightly

Fixed linting issues

Merge branch 'fix/remove-shared-cache' of https://github.com/TheSharpieOne/react-select into TheSharpieOne-fix/remove-shared-cache

Merge pull request JedWatson#1255 from rockingskier/master

Merge pull request JedWatson#1300 from DanielHeath/fix-firefox-alignment

Merge pull request JedWatson#1289 from DanielHeath/clear-async-after-selection

Fix issues JedWatson#1272 and JedWatson#1287

Clear Async options after making a selection

Merge pull request JedWatson#1292 from DanielHeath/opt-out-of-clearing-options

Merge pull request JedWatson#1293 from DanielHeath/add-async-no-results-text

Merge pull request JedWatson#1290 from DanielHeath/prevent-merging-built-files

Merge pull request JedWatson#1291 from DanielHeath/trailing-whitespace

Allow users to specify noResultsText

Only remove options if a loading placeholder is available

Whitespace

Tell git not to merge built files

Merge pull request JedWatson#1288 from raianand/patch-1

Fixed incorrect prop(onCloseResetsInput) in Readme

Merge pull request JedWatson#1281 from jtulk/patch-1

Merge pull request JedWatson#1257 from jooj123/patch/add-back-on-input-change

Documentation to backspaceToRemoveMessage Property

Merge pull request JedWatson#1265 from strayiker/master

Remove unit (px) from minWidth attribute

Use attachEvent/detachEvent for IE8 compability

Merge pull request JedWatson#1260 from DanielHeath/patch-1

Allow react nodes to be passed as loadingPlaceholder

Add back onInputChange

Fix typo in README.md

Merge pull request JedWatson#1248 from IvanLeonenko/creatable-input-keys

Merge pull request JedWatson#1249 from jooj123/patch/add-ref

Adding back ref that was removed in rc2

Add unit test for fix - Creatable doesn't allow input key down handling. JedWatson#1247

Fix for Creatable doesn't allow input key down handling. Issue JedWatson#1247

fix(async): create new cache object for each instance by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment