New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 0.14.0-beta1 + remove former hacky attempts to handle React eventpooling problem #52

Merged
merged 3 commits into from Jul 29, 2015

Conversation

Projects
None yet
2 participants
@slorber
Contributor

slorber commented Jul 29, 2015

No description provided.

slorber added some commits Jul 29, 2015

Remove bad workarounds to solve the React event pooling problem on tap
The solution is to fire the tap event always synchronously (already fixed).
So the React event pooling can behave as usual.

Removed the attempt to assign an empty function to preventDefault, because it does not make sense to assign a function to a SyntheticEvent that has been put back in the pool. It should be the role of React to be defensive agaiin using preventDefault on events that are already put back in the pool. (See facebook/react#3657 (comment) )
Support usage of 0.14.0-beta1
This may seems to be a weird solution but has been used in other libs as well

See gaearon/react-hot-api#18
@slorber

This comment has been minimized.

Contributor

slorber commented Jul 29, 2015

sorry to give you additional work @JedWatson :)

@JedWatson

This comment has been minimized.

Owner

JedWatson commented Jul 29, 2015

No problem @slorber :)

One more release tonight by the looks of things!

JedWatson added a commit that referenced this pull request Jul 29, 2015

Merge pull request #52 from slorber/master
Support 0.14.0-beta1 + remove former hacky attempts to handle React eventpooling problem

@JedWatson JedWatson merged commit a56855a into JedWatson:master Jul 29, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment