Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Groove markers are giving me files in the tens of megabytes, even on projects with little in them. #297

Closed
Jeff0S opened this issue Jul 8, 2014 · 9 comments
Closed

Groove markers are giving me files in the tens of megabytes, even on projects with little in them. #297

Jeff0S opened this issue Jul 8, 2014 · 9 comments
Labels
bug imported OpSys-All Priority-High

Comments

@Jeff0S
Copy link
Member

Jeff0S commented Jul 8, 2014

From musicbynumbers@gmail.com on May 21, 2011 21:25:48

I'm not sure how this has started happening but at the bottom of my reaper files in the sws section I get this kind of text but it repeats enough times to get it up to about 30 meg on a song with only 2 audio files.

TIMESEL 0 5 0.00000000000000 0.00000000000000
<FNGGROOVE
  <GROOVEMARKERS
    GRV_0 100 21.33333333
    GRV_1 101 21.33350625
    GRV_2 102 21.99075387
    GRV_3 103 22.1696124
    GRV_4 104 22.33449907
    GRV_5 105 22.50008237
    GRV_6 106 23.15782013
    GRV_7 107 23.62301771
    GRV_8 108 24.68026258
    GRV_9 109 24.84789013
    GRV_10 110 24.99303105
    GRV_11 111 25.16372495
    GRV_12 112 26.31467632
    GRV_13 113 27.9975975
    GRV_14 114 28.49783145
    GRV_15 115 28.98238856
    GRV_16 116 29.73109604
    GRV_17 117 30.06008
    GRV_18 118 30.39106997
    GRV_19 119 30.56157996
    GRV_20 120 30.71002394
    GRV_21 121 31.21152389
    GRV_0 100 21.33333333
    GRV_1 101 21.33350625
    GRV_2 102 21.99075387
    GRV_3 103 22.1696124
    GRV_4 104 22.33449907
    GRV_5 105 22.50008237
    GRV_6 106 23.15782013
    GRV_7 107 23.62301771
    GRV_8 108 24.68026258
    GRV_9 109 24.84789013
    GRV_10 110 24.99303105
    GRV_11 111 25.16372495
    GRV_12 112 26.31467632
    GRV_13 113 27.9975975
    GRV_14 114 28.49783145
    GRV_15 115 28.98238856
    GRV_16 116 29.73109604
    GRV_17 117 30.06008
    GRV_18 118 30.39106997
    GRV_19 119 30.56157996
    GRV_20 120 30.71002394
    GRV_21 121 31.21152389
    GRV_0 100 21.33333333
    GRV_1 101 21.33350625
    GRV_2 102 21.99075387
    GRV_3 103 22.1696124
    GRV_4 104 22.33449907
    GRV_5 105 22.50008237
    GRV_6 106 23.15782013
    GRV_7 107 23.62301771
    GRV_8 108 24.68026258
    GRV_9 109 24.84789013
    GRV_10 110 24.99303105

It just goes on and on like that. any ideas? I only have the standard grooves installed too.

What version of SWS extension are you using? (Extensions -> About SWS...)

Beta 2.0.0.24 What is your Reaper version number and CPU architecture (e.g. Reaper 3.75 x64)? reaper beta 6 32bit with win7 64bit. What operating system are you running? (e.g. Windows XP/7, OSX 10.5.8 etc, 64bit?)

Original issue: http://code.google.com/p/sws-extension/issues/detail?id=297
@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From musicbynumbers@gmail.com on May 21, 2011 12:26:45

Also, this was a brand new song and as far as I know in all the songs that this has happened too I haven't even used groove at all :)

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From musicbynumbers@gmail.com on May 21, 2011 12:40:50

Also, I think every time I save the groove info above copies itself completely therefore it very quickly escalates into very massive files.

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From musicbynumbers@gmail.com on May 21, 2011 12:43:53

Sorry :) last comment!

It could be a problem in my initial default reaper project as it has these marker bits..

I've attached my default project to see if it makes sense to you :)

Attachment: default.RPP

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From swstim on May 21, 2011 17:54:22

Thanks MBN.

Fingers, have a few minutes to fix this soon? I took a quick look and 1) you should probably clear your list on BeginLoadProjectState, and probably check for dupes and not add in AddGrooveMarker.

If you're busy let me know and I can fix for you too, just wanted to give you first crack at it.

Status: Accepted
Owner: fingersmcgarnickle
Labels: -Priority-Medium Priority-High

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From musicbynumbers@gmail.com on May 21, 2011 18:59:43

Thanks for looking at this guys! :)

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From fingersmcgarnickle on May 21, 2011 19:22:37

Oh dear. Sorry about this :( Ideally I'd like to get rid of the groove markers before saving but this is not possible. Will fix ASAP!

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From fingersmcgarnickle on May 21, 2011 20:29:01

Should be fixed now. I have changed the behaviour to only use the groove marker stuff in the project to delete the markers when loading. I think this makes the most sense as grooves are not saved in the project, so toggling a groove in another reaper session doesn't really make much sense.

For your large buggy projects you will just have to save them again and they will go back to normal! Sorry for the f*ck up, and thanks for the bug report.

Status: Fixed

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From musicbynumbers@gmail.com on May 22, 2011 01:55:24

Thanks! :)

Very much appreciated!

@Jeff0S
Copy link
Member Author

Jeff0S commented Jul 8, 2014

From swstim on May 22, 2011 20:43:12

Added to v2.0.0 #25

Commits r483 r484 r485 r486

@Jeff0S Jeff0S closed this as completed Jul 8, 2014
@swstim swstim mentioned this issue Sep 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug imported OpSys-All Priority-High
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Jeff0S