fix schemaLocation namespace issue and import schemas #2
Conversation
add support to import schemas
|
Thank you for submitting this pull request! I appreciate your interest in improving Gepsio. Can you tell me more about the issue here and what the modifications are trying to solve? |
|
FYI - Justin W (@jwendl) recommended your repo to experiment with for my client POC.
I wanted to load a large XBRL (mmm-20161231.xsd) and "imports" were not
being loaded. I added "TestXbrl" project to my fork. I don't remember all
of the errors since I wrote this code a few months ago. I could
temporarily remove the new code to refresh my memory, if needed.
If I remember correctly, I made some improvements to import this reference and all associated nested imports.
<import namespace="http://www.xbrl.org/2003/instance" schemaLocation="http://www.xbrl.org/2003/xbrl-instance-2003-12-31.xsd" />
…On Wed, Sep 13, 2017 at 9:34 AM, Jeff Ferguson ***@***.***> wrote:
Thank you for submitting this pull request! I appreciate your interest in
improving Gepsio.
Can you tell me more about the issue here and what the modifications are
trying to solve!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKMPs-J0tnD8Hj28bE2DaQ1MBZCzUvHOks5sh-gKgaJpZM4PViI8>
.
|
|
Great! Justin is a good guy. I worked with him several years ago. I'll look over the pull request and see what jogs my memory! I've done a bit of work in that area lately, so some of it may have been (partially) solved. Thank you for trying Gepsio! Keep those suggestions coming. |
|
The other code change had to do with schemaLocation "namespace/location pairs". Fixed the TargetNamespace when necessary. There were cases where the Targetnamespace was null and I used the value (from the pair) to update it. mmm-20161231_cal.xml:<linkbase xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://www.xbrl.org/2003/linkbase" xmlns:xbrli="http://www.xbrl.org/2003/instance" xmlns:xlink="http://www.w3.org/1999/xlink" **xsi:schemaLocation="http://www.xbrl.org/2003/instance http://www.xbrl.org/2003/xbrl-instance-2003-12-31.xsd"**> |
|
closed it by accident |
|
strange, I only tried to submit the first commit. not sure how to fix it. |
This reverts commit 709df56.
|
seems like I should create a pull request for your develop branch |
|
moved to your develop branch. you can decider if/when you want to check it out. worked fine for testing the dutch taxonomy. |
|
Thank you, Jerry! Yes, changes should go against the |
|
Hi @jnettleton ... take a look at Issue 3 at #3 ... does your pull request solve this issue? Or is it a separate issue? |
fix schemaLocation namespace issue
add support to import schemas