Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc tune to Project.toml #51

Merged
merged 7 commits into from
Jul 14, 2020
Merged

Conversation

johnnychen94
Copy link
Contributor

@johnnychen94 johnnychen94 commented Jul 12, 2020

  • moves some test-only packages to [extras] section
  • slightly simplify the [compat] section
  • disable email notification from travis

Each commit is a small but independent change, please merge with squash if you feel them too many.

@codecov
Copy link

codecov bot commented Jul 12, 2020

Codecov Report

Merging #51 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #51   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files          48       48           
  Lines        2107     2107           
=======================================
  Hits         2082     2082           
  Misses         25       25           
Impacted Files Coverage Δ
src/fbp/sino_geom.jl 100.00% <ø> (ø)
src/plot/jim.jl 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abb2fff...324fd96. Read the comment docs.

Copy link
Owner

@JeffFessler JeffFessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: OK because 1.3 means [1.3,2) per
https://julialang.github.io/Pkg.jl/v1/compatibility/

I will merge these after tag for 0.12 goes through.

Copy link
Owner

@JeffFessler JeffFessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnnychen94 Sorry for the delay.
For some reason my version update is stuck in the Registrator for a long time:
JuliaRegistries/General#17858

Thanks for cleaning up these outdated [deps] entries.
Did you find these by hand or is there some tool that automates it?

@johnnychen94
Copy link
Contributor Author

johnnychen94 commented Jul 14, 2020

Thanks for cleaning up these outdated [deps] entries.
Did you find these by hand or is there some tool that automates it?

Because I am not familiar with MIRT, I simply did a search for every package in Project.toml and checked if this is apparently a test-only dependency....

https://github.com/bcbi/CompatHelper.jl is a tool that sends a PR notification for every new version of every dependency. An example of such PR can be found in JuliaImages/Images.jl#880

@JeffFessler JeffFessler merged commit 21ac1d5 into JeffFessler:master Jul 14, 2020
@johnnychen94 johnnychen94 deleted the jc/misc_tune branch July 15, 2020 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants