{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":372922863,"defaultBranch":"master","name":"cockroach","ownerLogin":"JeffSwenson","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2021-06-01T18:13:54.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/5283435?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1721051276.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"5a68aaa15d7044e394b93b7ca78c8ddb7fcee150","ref":"refs/heads/swenson-24-1-1-custom-build","pushedAt":"2024-07-15T13:47:56.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"JeffSwenson","name":"Jeff Swenson","path":"/JeffSwenson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5283435?s=80&v=4"},"commit":{"message":"pkg/cli: only flush logs during startup when running under systemd\n\nPreviously, `log.FlushAllSync()` was called before sending the signal\nreadiness to systemd to ensure that the configuration logging is written to\ndisk in case a process is waiting for the sdnotify readiness to read\ninformation from there. However, that gets invoked even if the process isn't\nrunning under systemd, and process start ups would take an unnecessary hit on\nperformance. This commit addresses that by running `FlushAllSync`\nconditionally, i.e. only when the process is running under systemd.\n\nEpic: none\n\nRelease note (performance improvement): Starting a cockroach process will no\nlonger flush buffered logs to configured logging sinks unless the process is\nrunning under systemd, where cockroach runs with the `NOTIFY_SOCKET`\nenvironment variable.","shortMessageHtmlLink":"pkg/cli: only flush logs during startup when running under systemd"}},{"before":null,"after":"1959ccd2d81cd6170689dc20e4a2afc7800f4566","ref":"refs/heads/jeffswenson-fix-proxy-test-timeout","pushedAt":"2024-03-18T14:19:06.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"JeffSwenson","name":"Jeff Swenson","path":"/JeffSwenson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5283435?s=80&v=4"},"commit":{"message":"sqlproxyccl: fix test\n\n<what was there before: Previously, ...>\n<why it needed to change: This was inadequate because ...>\n<what you did about it: To address this, this patch ...>","shortMessageHtmlLink":"sqlproxyccl: fix test"}},{"before":null,"after":"07412c3a0f48a9a83a09b2b956c3eb48c9ddba42","ref":"refs/heads/jeffswenson-tenant-throttling-with-admission-control","pushedAt":"2024-02-14T14:15:45.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"JeffSwenson","name":"Jeff Swenson","path":"/JeffSwenson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5283435?s=80&v=4"},"commit":{"message":"tenantcostserver: use high priority admission control","shortMessageHtmlLink":"tenantcostserver: use high priority admission control"}},{"before":null,"after":"480882fdb6e7cb544e0e36ab97ab4c89f9e43c0a","ref":"refs/heads/jeffswenson-improve-throttle-error","pushedAt":"2024-01-09T16:38:43.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"JeffSwenson","name":"Jeff Swenson","path":"/JeffSwenson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5283435?s=80&v=4"},"commit":{"message":"sqlproxyccl: improve authentication throttle error\n\nThe sql proxy will throttle connection attempts if a (client IP, tenant\ncluster) pair has too many authentication failures. The error is usually\ncaused by a misconfigured password in a connection pool. This change\nreplaces the \"connection attempt throttled\" error message with \"too many\nfailed authentication attempts\". There is a hint that includes this\nmessage but not all drivers are configured to log hints.\n\nFixes #117552","shortMessageHtmlLink":"sqlproxyccl: improve authentication throttle error"}},{"before":null,"after":"f3a28a622fcd25885c6e6ae00c65d2013141dad7","ref":"refs/heads/jeffswenson-fix-test-refresh-throttling","pushedAt":"2023-12-26T21:17:50.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"JeffSwenson","name":"Jeff Swenson","path":"/JeffSwenson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5283435?s=80&v=4"},"commit":{"message":"sqlproxyccl: delete destroy tenant portion of refresh throttling test\n\nTestRefreshThrottling is flakey because the test tenant directory server\ndetects the shut down of the tenant sql server and pushes an event to\nthe cache via the watch api. If the DELETE event is delivered to the\ncache before the pods are queried, the test flakes.\n\nFixes: #115139","shortMessageHtmlLink":"sqlproxyccl: delete destroy tenant portion of refresh throttling test"}},{"before":"7f66ac5427ce350e2f9997c1120422ab129fac80","after":"8db93a06786ce312f494810e73c6741c9bd02f63","ref":"refs/heads/jeffswenson-deflake-sqlproxy-cancel-test","pushedAt":"2023-09-26T19:04:32.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"JeffSwenson","name":"Jeff Swenson","path":"/JeffSwenson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5283435?s=80&v=4"},"commit":{"message":"sqlproxyccl: deflake TestCancelQuery\n\nTestCancelQuery would clear metrics at the start of each test, assert\nthe metrics were zero, run the tests logic, then assert metrics\nincreased.\n\nThe test would flake if a cancel initiated by a previous test\nincremented metrics after the metrics were cleared and before they were\nasserted to equal zero.\n\nNow, the test snapshots the counts at the start of each test and ensures\nthe metrics have increased compared to the snapshot. Now if there is a\nrare racing metric increment the test will still pass.\n\nFixes: #109868\n\nRelease Note: none","shortMessageHtmlLink":"sqlproxyccl: deflake TestCancelQuery"}},{"before":"617f5819849a90c51d007249c85c37ace6be0489","after":"7f66ac5427ce350e2f9997c1120422ab129fac80","ref":"refs/heads/jeffswenson-deflake-sqlproxy-cancel-test","pushedAt":"2023-09-26T19:03:40.000Z","pushType":"push","commitsCount":0,"pusher":{"login":"JeffSwenson","name":"Jeff Swenson","path":"/JeffSwenson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5283435?s=80&v=4"}},{"before":null,"after":"617f5819849a90c51d007249c85c37ace6be0489","ref":"refs/heads/jeffswenson-deflake-sqlproxy-cancel-test","pushedAt":"2023-09-26T18:59:30.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"JeffSwenson","name":"Jeff Swenson","path":"/JeffSwenson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5283435?s=80&v=4"},"commit":{"message":"Merge #110279\n\n110279: kvserver: requests that acquire repl locks should use read-write path r=nvanbenschoten a=arulajmani\n\nFirst commit from https://github.com/cockroachdb/cockroach/pull/110201\r\n\r\nPreviously, {Get,Scan,ReverseScan}Requests all used the read-only\r\nexecution path. Things aren't so simple anymore, now that we want these\r\nrequests to be able to acquire replicated locks, which means they need\r\nto go through raft (and therefore the read-write execution path). This\r\npatch achieves exactly that.\r\n\r\nInforms https://github.com/cockroachdb/cockroach/issues/100193\r\n\r\nRelease note: None\n\nCo-authored-by: Arul Ajmani <arulajmani@gmail.com>","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1888215327\" data-permission-text=\"Title is private\" data-url=\"https://github.com/cockroachdb/cockroach/issues/110279\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/cockroachdb/cockroach/pull/110279/hovercard\" href=\"https://github.com/cockroachdb/cockroach/pull/110279\">cockroachdb#110279</a>"}},{"before":"d3ec7909ca1bf7e478f5d523ded9d05be515e14c","after":null,"ref":"refs/heads/backport23.1-109844","pushedAt":"2023-09-15T16:46:10.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"JeffSwenson","name":"Jeff Swenson","path":"/JeffSwenson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5283435?s=80&v=4"}},{"before":null,"after":"d3ec7909ca1bf7e478f5d523ded9d05be515e14c","ref":"refs/heads/backport23.1-109844","pushedAt":"2023-09-13T17:18:34.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"JeffSwenson","name":"Jeff Swenson","path":"/JeffSwenson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5283435?s=80&v=4"},"commit":{"message":"sql: fix system database survival on create or drop database\n\nRun the system database region survival promotion/demotion logic when\ncreating or dropping databases. This fixes a bug where creating a\ndatabase that survives region failures would not promote the system\ndatabase to survive region.\n\nThis logic is temporary and should be removed once RFC #109843 allows us\nto configure the system database as a mix of survive zone and survive\nregion.\n\nFixes: #109843","shortMessageHtmlLink":"sql: fix system database survival on create or drop database"}},{"before":"2b8d04746a79c54de36a273274ac9f6995632cfd","after":"9b5991d4d65e22ba7bb42d5a5e10e96089d4d477","ref":"refs/heads/jeffswenson-fix-create-db-with-survive-region","pushedAt":"2023-09-12T20:14:31.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"JeffSwenson","name":"Jeff Swenson","path":"/JeffSwenson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5283435?s=80&v=4"},"commit":{"message":"sql: fix system database survival on create or drop database\n\nRun the system database region survival promotion/demotion logic when\ncreating or dropping databases. This fixes a bug where creating a\ndatabase that survives region failures would not promote the system\ndatabase to survive region.\n\nThis logic is temporary and should be removed once RFC #109843 allows us\nto configure the system database as a mix of survive zone and survive\nregion.\n\nFixes: #109843","shortMessageHtmlLink":"sql: fix system database survival on create or drop database"}},{"before":"71bdf02d527b83f702e15f6627ea42cba929728d","after":"2b8d04746a79c54de36a273274ac9f6995632cfd","ref":"refs/heads/jeffswenson-fix-create-db-with-survive-region","pushedAt":"2023-09-11T18:54:14.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"JeffSwenson","name":"Jeff Swenson","path":"/JeffSwenson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5283435?s=80&v=4"},"commit":{"message":"sql: fix system database survival on create or drop database\n\nRun the system database region survival promotion/demotion logic when\ncreating or dropping databases. This fixes a bug where creating a\ndatabase that survives region failures would not promote the system\ndatabase to survive region.\n\nThis logic is temporary and should be removed once RFC #109843 allows us\nto configure the system database as a mix of survive zone and survive\nregion.\n\nFixes: #109843","shortMessageHtmlLink":"sql: fix system database survival on create or drop database"}},{"before":"3f28be7c609385e9f4d58a69a364f72433faadf6","after":null,"ref":"refs/heads/backport23.1-105591-105592-109290","pushedAt":"2023-09-07T16:22:29.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"JeffSwenson","name":"Jeff Swenson","path":"/JeffSwenson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5283435?s=80&v=4"}},{"before":"3e442759ffe6dd93bf0c6fb0b52a52b770f472f9","after":"3f28be7c609385e9f4d58a69a364f72433faadf6","ref":"refs/heads/backport23.1-105591-105592-109290","pushedAt":"2023-09-05T16:30:46.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"JeffSwenson","name":"Jeff Swenson","path":"/JeffSwenson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5283435?s=80&v=4"},"commit":{"message":"multitenantccl: add metric for network consumption\n\nPreviously, the cross region network portion of the RU consumption did\nnot get its own line item in the TenantConsumption proto or the tenant\nconsumption metrics. Now, the network component is removed from the kvRU\nfield. Network cost is recorded in the TenantConsumption proto and\nexported as its own consumption metric.\n\nThe cross region network cost table was added by #105592 and is not yet\ndeployed to production.\n\nRelease Note: None\n\nFixes: #108376","shortMessageHtmlLink":"multitenantccl: add metric for network consumption"}},{"before":"8235e2f95ed03a13723e0d553be2d89cea6b5300","after":"71bdf02d527b83f702e15f6627ea42cba929728d","ref":"refs/heads/jeffswenson-fix-create-db-with-survive-region","pushedAt":"2023-08-31T20:27:31.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"JeffSwenson","name":"Jeff Swenson","path":"/JeffSwenson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5283435?s=80&v=4"},"commit":{"message":"sql: fix system database survival on create or drop database\n\nRun the system database region survival promotion/demotion logic when\ncreating or dropping databases. This fixes a bug where creating a\ndatabase that survives region failures would not promote the system\ndatabase to survive region.\n\nThis logic is temporary and should be removed once RFC #109843 allows us\nto configure the system database as a mix of survive zone and survive\nregion.\n\nFixes: #109843","shortMessageHtmlLink":"sql: fix system database survival on create or drop database"}},{"before":"1f983b4942fe43151f4245f718a3b334ed1d5b97","after":"8235e2f95ed03a13723e0d553be2d89cea6b5300","ref":"refs/heads/jeffswenson-fix-create-db-with-survive-region","pushedAt":"2023-08-31T18:49:35.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"JeffSwenson","name":"Jeff Swenson","path":"/JeffSwenson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5283435?s=80&v=4"}},{"before":"8dda0ff7c8c9c70281592010aaba114f0928c566","after":"3e442759ffe6dd93bf0c6fb0b52a52b770f472f9","ref":"refs/heads/backport23.1-105591-105592-109290","pushedAt":"2023-08-30T20:00:13.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"JeffSwenson","name":"Jeff Swenson","path":"/JeffSwenson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5283435?s=80&v=4"}},{"before":null,"after":"8dda0ff7c8c9c70281592010aaba114f0928c566","ref":"refs/heads/backport23.1-105591-105592-109290","pushedAt":"2023-08-30T14:33:26.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"JeffSwenson","name":"Jeff Swenson","path":"/JeffSwenson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5283435?s=80&v=4"}},{"before":"47e0d8aac508b98ad9cd9dea8fa3513f5324384c","after":null,"ref":"refs/heads/backport23.1-105591-105592-109290","pushedAt":"2023-08-30T14:32:25.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"JeffSwenson","name":"Jeff Swenson","path":"/JeffSwenson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5283435?s=80&v=4"}},{"before":null,"after":"47e0d8aac508b98ad9cd9dea8fa3513f5324384c","ref":"refs/heads/backport23.1-105591-105592-109290","pushedAt":"2023-08-30T14:30:29.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"JeffSwenson","name":"Jeff Swenson","path":"/JeffSwenson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5283435?s=80&v=4"}},{"before":null,"after":"1f983b4942fe43151f4245f718a3b334ed1d5b97","ref":"refs/heads/jeffswenson-fix-create-db-with-survive-region","pushedAt":"2023-08-29T21:41:15.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"JeffSwenson","name":"Jeff Swenson","path":"/JeffSwenson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5283435?s=80&v=4"}},{"before":null,"after":"f0af18b77463527401068b18b37629b6cb7c4517","ref":"refs/heads/jeffswenson-sqlproxy-trace","pushedAt":"2023-08-23T21:30:47.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"JeffSwenson","name":"Jeff Swenson","path":"/JeffSwenson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5283435?s=80&v=4"},"commit":{"message":"sqlproxyccl: emit a single log line for each sqlproxy connection\n\n<what was there before: Previously, ...>\n<why it needed to change: This was inadequate because ...>\n<what you did about it: To address this, this patch ...>","shortMessageHtmlLink":"sqlproxyccl: emit a single log line for each sqlproxy connection"}},{"before":"f6b78dd711a3a8dadf0ae204ce87734199a5dc0f","after":"2171eca92cb9f7e2254e81efcb344e94c5b461bf","ref":"refs/heads/jeffswenson-network-metric","pushedAt":"2023-08-23T13:43:46.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"JeffSwenson","name":"Jeff Swenson","path":"/JeffSwenson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5283435?s=80&v=4"},"commit":{"message":"multitenantccl: add metric for network consumption\n\nPreviously, the cross region network portion of the RU consumption did\nnot get its own line item in the TenantConsumption proto or the tenant\nconsumption metrics. Now, the network component is removed from the kvRU\nfield. Network cost is recorded in the TenantConsumption proto and\nexported as its own consumption metric.\n\nThe cross region network cost table was added by #105592 and is not yet\ndeployed to production.\n\nRelease Note: None\n\nFixes: #108376","shortMessageHtmlLink":"multitenantccl: add metric for network consumption"}},{"before":"91c6dbcb9749ce20ec40faf05928c9adfca4c6b0","after":"f6b78dd711a3a8dadf0ae204ce87734199a5dc0f","ref":"refs/heads/jeffswenson-network-metric","pushedAt":"2023-08-22T21:35:07.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"JeffSwenson","name":"Jeff Swenson","path":"/JeffSwenson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5283435?s=80&v=4"}},{"before":"a7b9b39572d0c6dbbc138dca54ab3f875b37395e","after":"91c6dbcb9749ce20ec40faf05928c9adfca4c6b0","ref":"refs/heads/jeffswenson-network-metric","pushedAt":"2023-08-22T21:34:35.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"JeffSwenson","name":"Jeff Swenson","path":"/JeffSwenson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5283435?s=80&v=4"}},{"before":"ec35b6b541a9431cfd972694c1b638c98dc0488f","after":"a7b9b39572d0c6dbbc138dca54ab3f875b37395e","ref":"refs/heads/jeffswenson-network-metric","pushedAt":"2023-08-22T21:31:50.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"JeffSwenson","name":"Jeff Swenson","path":"/JeffSwenson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5283435?s=80&v=4"}},{"before":"b2e259fa1dc2c2f17d86903e40e1ad042ee72b67","after":"ec35b6b541a9431cfd972694c1b638c98dc0488f","ref":"refs/heads/jeffswenson-network-metric","pushedAt":"2023-08-22T20:51:32.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"JeffSwenson","name":"Jeff Swenson","path":"/JeffSwenson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5283435?s=80&v=4"}},{"before":"8bab4d69cdc3cb9bd20ad823296699e728346861","after":"b2e259fa1dc2c2f17d86903e40e1ad042ee72b67","ref":"refs/heads/jeffswenson-network-metric","pushedAt":"2023-08-22T20:41:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"JeffSwenson","name":"Jeff Swenson","path":"/JeffSwenson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5283435?s=80&v=4"}},{"before":null,"after":"8bab4d69cdc3cb9bd20ad823296699e728346861","ref":"refs/heads/jeffswenson-network-metric","pushedAt":"2023-08-22T20:12:17.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"JeffSwenson","name":"Jeff Swenson","path":"/JeffSwenson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5283435?s=80&v=4"}},{"before":"263a6abe4957f7b6d378b7735b1c5a19f26b8632","after":"4068ff261dff9882549d73297d7e67c58a7929d4","ref":"refs/heads/jeffswenson-region-liveness","pushedAt":"2023-08-16T14:25:32.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"JeffSwenson","name":"Jeff Swenson","path":"/JeffSwenson","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5283435?s=80&v=4"},"commit":{"message":"rfc: system.region_liveness\n\nCreate draft RFC for the `system.region_liveness` table.\n\nInforms: CC-24173\nRelease note: none","shortMessageHtmlLink":"rfc: system.region_liveness"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEf8HHyAA","startCursor":null,"endCursor":null}},"title":"Activity · JeffSwenson/cockroach"}