From 5799c468ecee40e6d65bdd21af866364f509ebee Mon Sep 17 00:00:00 2001 From: Felix Touchte Codjo <119527892+ftouchte@users.noreply.github.com> Date: Mon, 3 Nov 2025 18:58:02 +0100 Subject: [PATCH 1/2] Fix the wfType description I forgot to modify this comment when I made the study on the wfType. https://clasweb.jlab.org/wiki/images/b/b0/WfType-study.pdf --- .../java/org/jlab/detector/pulse/ModeAHDC.java | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/common-tools/clas-detector/src/main/java/org/jlab/detector/pulse/ModeAHDC.java b/common-tools/clas-detector/src/main/java/org/jlab/detector/pulse/ModeAHDC.java index b3a0b149c9..64c9817f1c 100644 --- a/common-tools/clas-detector/src/main/java/org/jlab/detector/pulse/ModeAHDC.java +++ b/common-tools/clas-detector/src/main/java/org/jlab/detector/pulse/ModeAHDC.java @@ -57,13 +57,13 @@ public class ModeAHDC extends HipoExtractor { private int effectiveNumberOfBins; //Waveform types: - //0 is good, - //-1 is invalid, - //1 is saturating, - //2 has too short of a baseline, - //3 is late and only has a rising edge, - //4 is a trailing edge from a previous wf, - //5 has low ADC ("flat") + //wfType 6 ⇒ too small (nsamples <= 10) + //wfType 5 ⇒ decreasing baseline (or leadingEdgeTime fails) + //wfType 4 ⇒ bad ToT (ToT < 300) + //wfType 3 ⇒ pileUp + //wfType 2 ⇒ bad trailingEdgeTime + //wfType 1 ⇒ saturing + //wfType 0 ⇒ OK /** * From 8506bb1ec9c85e2af5f0d6129a67df0e18b7712b Mon Sep 17 00:00:00 2001 From: Felix Touchte Codjo <119527892+ftouchte@users.noreply.github.com> Date: Mon, 3 Nov 2025 19:03:32 +0100 Subject: [PATCH 2/2] add comment for wfType 3 --- .../src/main/java/org/jlab/detector/pulse/ModeAHDC.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common-tools/clas-detector/src/main/java/org/jlab/detector/pulse/ModeAHDC.java b/common-tools/clas-detector/src/main/java/org/jlab/detector/pulse/ModeAHDC.java index 64c9817f1c..7cd68df1b1 100644 --- a/common-tools/clas-detector/src/main/java/org/jlab/detector/pulse/ModeAHDC.java +++ b/common-tools/clas-detector/src/main/java/org/jlab/detector/pulse/ModeAHDC.java @@ -60,7 +60,7 @@ public class ModeAHDC extends HipoExtractor { //wfType 6 ⇒ too small (nsamples <= 10) //wfType 5 ⇒ decreasing baseline (or leadingEdgeTime fails) //wfType 4 ⇒ bad ToT (ToT < 300) - //wfType 3 ⇒ pileUp + //wfType 3 ⇒ pileUp // TO BE DONE //wfType 2 ⇒ bad trailingEdgeTime //wfType 1 ⇒ saturing //wfType 0 ⇒ OK