New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #300 by segregating source from destination #304
Conversation
This PR really got me thinking about the file structure. We have three directories where the bulk of the assets are:
The compiled/minified files are in those directories, while the working files are a directory deeper. This is consistent across these directories - which is great. But would it make more sense to have the compiled/minified files be the "deeper" files?
@garrett-eclipse, I'd love your thoughts on this. z |
Thanks @JeremyEnglert imho I feel even more distinction would be beneficial this would make it easier to check in only the source and push to production without the source files. I'm thinking something like; Thinking with this structure your .gitignore can exclude the entire /assets directory. And if you have a deploy script you can have it exclude the entire source directory. Just my two cents |
This fix works for me however I was wondering if there was a way to setup a remove task which watches the src folder and if the image is not in the src folder then remove it from the optimized images folder? |
Thanks @jackfearing that's a good idea, can you spawn a unique ticket for that request so it can be accommodated properly. Cheers |
Thanks Garrett -- just submitted a new ticket. #360 |
Sorry I messed up my PRs by using my master. Closing this to cleanup and reopen via a branch. |
Created PR #312 to replace this. @JeremyEnglert I didn't find the gulp-improvements branch yet. When that's setup will you handle the further separation of directories as discussed in this PR? |
This fix avoids the infinite loop of imagemin when watching