Jeremy Skinner JeremySkinner

Organizations

@ClockworkIntellect
@JeremySkinner

This is how MVC works. There are multiple places where MVC tries to obtain the validator - it tries to get metadata for each property, and calls in…

@JeremySkinner

I am away with work until September, so I'm not going to have much chance to work on it until then I'm afraid. I expect mid/end September will be t…

@JeremySkinner

Ok, I didn't think it would work, but it was worth a try. Unfortunately I still have nothing to go on - I can't reproduce the issue, and the stack …

@JeremySkinner

Great, I'm glad it's sorted.

@JeremySkinner
Installing through NuGet on VS2013 For Web
@JeremySkinner

Unfortunately I don't have the time to support multiple versions of MVC - I don't support mvc4 anymore, so I locked it to the last version I tested…

@JeremySkinner

Ok, I'm running VS2013 Update 4 and Nuget 2.8

@JeremySkinner

I just tried it on a blank 4.5 project (in vs2013) and it worked fine. Are you running the updates of VS2013 and nuget?

@JeremySkinner

Which .net version are you targeting? On Monday, July 27, 2015, sqzr1 notifications@github.com wrote: Hello Installing Fluent Validation in Visual…

@JeremySkinner
@JeremySkinner
@JeremySkinner
JeremySkinner commented on pull request JeremySkinner/SagePayMvc#7
@JeremySkinner

Thanks, that's merged in.

@JeremySkinner
@JeremySkinner
Added support for mail order account type
6 commits with 68 additions and 21 deletions
@JeremySkinner

There isn't any contextual information when generating client-side rules, so anything that is cross-property won't work client-side. I'd suggest mo…

@JeremySkinner

I've committed the change. Please give it a try and let me know whether or not it seems to make a difference.

@JeremySkinner
  • @JeremySkinner eded2b2
    Hopefully make PropertyValidatorContext.PropertyValue more threadsafe
@JeremySkinner

OK, let me know what you decide. I'm happy to make the change to the source - it should be fairly quick, but then you'd be 'on your own' with it un…

@JeremySkinner

I'm away with work until early September, so not until then at the earliest I'm afraid. Your best bet would be to build from source and patch it yo…

@JeremySkinner

That could indeed be the issue - the validators themselves are designed to be thread-safe, but PropertyValidatorContext is not. The idea was always…

@JeremySkinner

Unfortunately that's not really enough to go on. Unless there's some reliable steps to reproduce it there's not much I can do.

@JeremySkinner

I can make it virtual if that would help, although I'd usually recommend passing dependencies in through the constructor.

@JeremySkinner
  • @JeremySkinner 9f36cce
    Update signature verification
@JeremySkinner

I agree - it's a bit redundant. Still, I'll make the fix.

@JeremySkinner

Thanks. I've added the property - let me know if that works.

@JeremySkinner
  • @JeremySkinner 65d4a02
    Add SecurityKey to RefundResponse
@JeremySkinner
Added lambdas on LengthValidator and RegularExpressionValidator to ac…
@JeremySkinner

I've merged this into the latest commit. Thanks again.

@JeremySkinner