Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(syncer): restore tiddlerInfo param to saveTiddler #4584

Merged
merged 1 commit into from Apr 20, 2020

Conversation

danielo515
Copy link
Contributor

This was added on a159b5b and lost in #4373.
Will be a good idea to introduce tests against this kind of changes

This was added on a159b5b and lost in Jermolene#4373.
Will be a good idea to introduce tests against this kind of changes
@Jermolene
Copy link
Owner

Thanks @danielo515

@Jermolene Jermolene merged commit 4ea79cb into Jermolene:master Apr 20, 2020
@danielo515 danielo515 deleted the patch-8 branch April 20, 2020 10:21
@Jermolene
Copy link
Owner

@danielo515 this PR appears to be broken; I'm seeing:


 syncer-server-filesystem: Dispatching 'save' task: $:/StoryList 
$:/core/modules/syncer.js:587
			tiddlerInfo: self.tiddlerInfo[task.title]
			                              ^

ReferenceError: task is not defined
    at SaveTiddlerTask.run ($:/core/modules/syncer.js:587:34)
    at Syncer.processTaskQueue ($:/core/modules/syncer.js:478:9)
    at Function.<anonymous> ($:/core/modules/syncer.js:90:9)
    at $tw.Wiki.exports.dispatchEvent ($:/core/modules/wiki.js:133:13)
    at $:/core/modules/wiki.js:166:10
    at processTicksAndRejections (internal/process/task_queues.js:76:11)

Jermolene added a commit that referenced this pull request Apr 20, 2020
Fixes a bug introduced in #4584
@Jermolene
Copy link
Owner

See 2649d2f for fix

@danielo515
Copy link
Contributor Author

Thanks for the fix @jeremy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants