Fully committing core to the $genesis widget #7129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
13 tasks
I meant to say thank you for the kind words! |
|
Thank you for your patience @flibbles |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I love the new genesis widget.
It's great. It provides a far better mechanism for dynamic widgets than the old way, which was to do placeholder widget like this:
\define macro(tag:div) <$tag$>...Placeholder widgets were bad for plugin developers like me. Take Uglify. It can't parse <$tag$>, so it actually saw it as plaintext containing a placeholder. And all it could do was stay away from it, because touching it was dangerous. As a result, Uglify becomes much less effective around them. But it can handle
<$genesis>just fine. It's safer. It compresses better.Even Relink prefers $genesis. If it encountered
<$tag$ attribute=...>, it couldn't relink any of its attributes at all, because it couldn't parse it as a widget. With $genesis, it can. (It may still fail to identify some string-value attributes that require relinking in some cases, but it's still far better off with a $genesis widget).In fact, my only complaint about the genesis widget is this:
Why aren't we fully embracing it?
This PR addresses that by migrating the few remaining places in core where dangerous placeholder widgets were still used.