Bug-fix patch for #404 #539

Merged
merged 1 commit into from Jan 22, 2014

Conversation

Projects
None yet
3 participants
Contributor

cwhelchel commented Jan 22, 2014

Surround web call with a try...catch. The exception is silently ignored but needs to be logged.

ref #394

@cwhelchel cwhelchel Bug-fix patch for #404
Surround web call with a try...catch. The exception is silently ignored but needs to be logged.

ref #394
cb37020
Contributor

cwhelchel commented Jan 22, 2014

I should note that this is largely untested. So to those having this issue in issue 404, please test.

Contributor

FrozenHaxor commented Jan 22, 2014

Testing overnight. Will post results tomorrow.

EDIT: Appears to be working fine so far.

@Jessecar96 Jessecar96 added a commit that referenced this pull request Jan 22, 2014

@Jessecar96 Jessecar96 Merge pull request #539 from cwhelchel/fix/i404
Bug-fix patch for #404
5b03ad5

@Jessecar96 Jessecar96 merged commit 5b03ad5 into Jessecar96:master Jan 22, 2014

Contributor

FrozenHaxor commented Jan 26, 2014

Unfortunately this is still an issue. CurrentTrade will never get set to null and the bot will not accept a new trade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment