-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix for status 6 (e-mail confirmations) #732
Conversation
Slightly modified status 2.
|
Ref: issue #708 |
|
I don't think firing the error handler when the trade completes with "email pending" is the correct behavior. |
|
In that case we would need to add new method to Ideally, we should have a single "trade ended" handling method which takes |
|
There doesn't seem to be a good, backwards-compatible solution. So perhaps we should just do that. |
|
I say we let bot programmer decide what to do on trade end |
|
Well I haven't kept up to date that much on SteamBot so I'm not sure if it even supports trade offers natively. It should check for outgoing offers every X seconds (or check on the event for that if there is one) to see when the offer is accepted, then fire the success event, and if it was declined fire the error event. |
|
The problem is inconsistency on Valve's part. Mostly the trades appear as "Items now unavailable for trade" and such after being accepted by both parties and sometimes it shows it correctly. They messed it up big time. |
|
There currently isn't an accurate and exploit-free way to determine if a trade-offer has been completed. We discussed this to death in another thread. But that's not what we're talking about here - we're talking about what to do when a normal trade gets turned into a trade offer due to an email-confirmation. |
|
@BlueRaja Adding to my first reply to you, I just realized that if the proposed |
|
BTW. One more thing I have noticed. Trades sometimes end with status 6 even if both users have the e-mail confirmations disabled. The items are exchanged immediately though. |
I confirm this. It's actually happening quite often. |
|
When that happens, are we given a trade-offer id we can check? Does that trade offer immediately complete successfully, or does it sometimes conclude with "Items not available" like normal trade-offers sometimes do? |
|
The trade offer is instantly marked as "Items unavailable". Another issue which makes the system completely unreliable. |
|
Before this gets merged, I think this PR should either create the |
|
I added a new callback: #746 |
|
I'm closing this PR. Discussion continues in #746. |
This hasn't been fixed yet so I'm opening a PR to get this sorted out ASAP.
There are couple small changes:
tradeidin TradeStatus.csCurrently, the way we handle errors, it's not possible to provide
tradeidto be handled directly in the UserHandler. This could be improved.