feat: api videos authentication #3316
Open
+744
−304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeallisonJS
added
effort: 5
priority: soon
type: feat
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
The latest updates on your projects.
|
|
The latest updates on your projects.
|
|
The latest updates on your projects.
|
|
The latest updates on your projects.
|
|
The latest updates on your projects.
|
|
The latest updates on your projects.
|
tataihono
requested changes
Aug 27, 2024
Comment on lines
262
to
270
| currentVideoRoles: t.field({ | ||
| type: [VideoAdminUserRole], | ||
| nullable: false, | ||
| authScopes: { | ||
| isAuthenticated: true | ||
| }, | ||
| resolve: async (_query, _args, ctx: Context) => | ||
| ctx.currentVideoUser?.roles ?? [] | ||
| }) |
There was a problem hiding this comment.
can we break this out into a user file and just extend the user object out? that way the me call could be:
me {
id
videoUserRoles {
id
roles
}
}
| describe('usesr', () => { | ||
| const authClient = getClient({ | ||
| headers: { | ||
| authorization: 'token' |
Check failure
Code scanning / CodeQL
Hard-coded credentials Critical test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue
videos admin frontend needs specific authentication.
Solution
Add authentication & query to api-videos