Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Concatenation hat ^ #26

Closed
nesteruk opened this Issue · 8 comments

2 participants

@nesteruk
Owner

"" ^ "" //op_Concatenate

@nesteruk
Owner

Also broken for UoM

@citizenmatt
Owner

Added the CARET token as part of 66b436b.

What's UoM?

@nesteruk
Owner

@citizenmatt ugh... trying to remember..... no idea

@citizenmatt
Owner

Ah. Units of Measure - can you remember the details?

@nesteruk
Owner

Oh yeah, I can now. Basically, when using UoM, you might have things like m^2 (meters squared), so I guess it's relevant there too

@citizenmatt
Owner

Guess there's going to be loads of stuff to do with UoM, but not strictly relevant to the caret symbol. I'm closing this for now.

@nesteruk
Owner

Here's the case that failed for UoM:

let…gravityOnEarth…=…9.81<m/s^2>

@citizenmatt
Owner

Add a test for it. Think it's worth adding failing tests for all these issues you're finding. Adding an issue for each lexing failure, without a test case is just going to cause more work further on - managing issues, recreating. Add the failing tests in a new branch, and set up a pull request immediately to start working on it.

Like this:
https://github.com/blog/1124-how-we-use-pull-requests-to-build-github

and set the description of the pull request to include check boxes which can be marked off as the tests are fixed:

https://github.com/blog/1375-task-lists-in-gfm-issues-pulls-comments

Or, close the little issues and add the individual errors as task lists in issue #1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.