Skip to content

Implement FSharpMissingTokensInserter.Run method #52

Closed
ollka opened this Issue Apr 6, 2013 · 5 comments

4 participants

@ollka
ollka commented Apr 6, 2013

See PSI plugin for hint.

@OkayX6
OkayX6 commented Apr 7, 2013

What's the spec of this function?
How difficult is it?

@ollka
ollka commented Apr 8, 2013

See PsiPlugin sources for example. You could find them in SDK path directory somewhere near:
C:\Program Files (x86)\JetBrains\ReSharper\v7.1\SDK\Samples\PsiPlugin\src\Psi\Psi\Parsing\

This function should insert comments and other spaces into PSI tree.

@nesteruk nesteruk added a commit that closed this issue May 9, 2013
@nesteruk nesteruk fixes #52
but what did I just fix?
269ced9
@nesteruk nesteruk closed this in 269ced9 May 9, 2013
@nesteruk
JetBrains member
nesteruk commented May 9, 2013

I've copied over the stuff from the SDK but honestly, I have no idea what it is, and something tells me the implementation for F# could be different seeing how it's a whitespace-significant language.

@citizenmatt
JetBrains member

Well, wouldn't it be better to understand what we're adding in, rather than blindly copying code where we've got no idea what it does?

@nesteruk
JetBrains member
nesteruk commented May 9, 2013

It totally would, so I hope @ollka can explain exactly what this business of whitespace insertion is for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.