Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ligatures for Perl and Julia and matlab Languages are confusing #76

Closed
cems2 opened this issue Jan 21, 2020 · 4 comments
Closed

Ligatures for Perl and Julia and matlab Languages are confusing #76

cems2 opened this issue Jan 21, 2020 · 4 comments
Labels
bug Something isn't working
Milestone

Comments

@cems2
Copy link

cems2 commented Jan 21, 2020

Common Julia and matlab symbol combinations are
.- which JBMono renders •- turning the . into a bullet
... which JBMono renders . .. adding adding space between two of the dots in the ellipsis

I note that the .- in Julia and Matlab are part of family of symbol expressions that prefix a period before a symbol that include .+ .* ./ and .- of these only the .- one is modified to something that doesn't suggest it's intent, so the ligature seems inconsistent.

While not a ligature, the backslash and forward slash extend all the way to the edge of the character width allowing them to visually blend with the next character in what looks like a new ligature arrow-like symbol that obfuscates the intent /\ and \/ instead of / \ or \ / . Even worse Other characters also blend with these slashes such as /> to produce something unreconizable

note: While this is not unique to JBMono it is specifically detrimental for Developers, the target audience of JBMono. the backslash is the all important escape character in most languages.

@philippnurullin
Copy link
Member

@cems2 Can you send me the version of IDE you using? The problem with ..should be solved in recent versions.

Understood the context of using .-, i will add the exclusion for this ligature.

The escape sequence ligature problem will be fixed in 1.0.2 #78

@philippnurullin philippnurullin added the bug Something isn't working label Jan 22, 2020
@cems2
Copy link
Author

cems2 commented Jan 22, 2020 via email

@philippnurullin
Copy link
Member

The \/ & /\ ligatures will be removed in v 1.0.3.

philippnurullin added a commit that referenced this issue Feb 7, 2020
— Added support of Box Drawings 159 symbols #84 #55
— Added ligature `<--` #95
— Removed the `\/` & `/\` ligatures #65 #76 #78 #83
— Corrected behaviour of ligatures in a glob pattern #88
— Changed the `$` & dependent glyphs #110
— Added no-break space #94
— Corrected unexpected `>=` ligature usage in `>=<` sequence 
— Refactored `w`, `W`, `m`, `M`
— Slightly tuned ascenders & descenders
— Added support of Mongolian language #81
— Better placement of the dot in 0 #104
— Reorganised family names #122
philippnurullin added a commit that referenced this issue Feb 7, 2020
— Added support of Box Drawings 159 symbols #84 #55
— Added ligature `<--` #95
— Removed the `\/` & `/\` ligatures #65 #76 #78 #83
— Corrected behaviour of ligatures in a glob pattern #88
— Changed the `$` & dependent glyphs #110
— Added no-break space #94
— Corrected unexpected `>=` ligature usage in `>=<` sequence 
— Refactored `w`, `W`, `m`, `M`
— Slightly tuned ascenders & descenders
— Added support of Mongolian language #81
— Better placement of the dot in 0 #104
— Reorganised family names #122
— Updated download link in README.md
@philippnurullin
Copy link
Member

tonsky/FiraCode#670

@philippnurullin philippnurullin added this to the v2.300 milestone Dec 18, 2020
philippnurullin added a commit that referenced this issue Dec 21, 2020
- Removed `.-` ligature #76
- Disabled ligatures for lookahead/lookbehind prefixes (regex) #126
- Added support for combined marks #228
- Added `∪` #244
- Added `➜`(U+279C), `✗`(U+2717), and `✓`(U+2713) #246
- Added `<<~` #291
- Added `‾` Overline #298
- Tuned Cyrillic `в` #335
- Increase BoxDraving. Top +100, bottom +100 #382
- Added `‿` `∁` `∎` `⊸` `⊎` `⨀` `⨆` `∩` `∶` `⊢` `⊤` `⊥` `⊛` `⊖` `⊗` `⊙` `⊕` `◦` `⋆` `ℚ` `ℤ` `slashshortcomb`
- Corrected placement of bar in italic `Đ`
- Polished Digits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants