Check plugin dependencies on generation #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check_IdeaPlugin_Dependencies rule doesn't take into account runtimes of used languages because it doesn't have that information in the model. So if a model uses a language that is not otherwise included as a dependency, no errors were reported in the editor but this missing dependency would lead to ClassNotFoundExceptions later on. The information is available during the generation time after modules are loaded, so perform a check at that time as a last resort.
|
Will redo this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check_IdeaPlugin_Dependencies rule doesn't take into account
runtimes of used languages because it doesn't have that information in
the model. So if a model uses a language that is not otherwise included
as a dependency, no errors were reported in the editor but this missing
dependency would lead to ClassNotFoundExceptions later on.
The information is available during the generation time after modules
are loaded, so perform a check at that time as a last resort.