Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIM-1274 Fix StringHelper.containsUpperCase behavior #160

Merged
merged 1 commit into from Sep 21, 2018

Conversation

@johnlinp
Copy link
Contributor

@johnlinp johnlinp commented Sep 14, 2018

StringHelper.containsUpperCase should return true when one of
the character of the input string satisfies the following two
conditions:

  1. The character is upper case.
  2. The character is not prefixed with a backslash.

Before this fix, the second condition was incorrectly written.

Copy link
Member

@vlasovskikh vlasovskikh left a comment

Thanks for your pull request! Could you please add a unit test for it into SearchGroupTest?

Loading

@vlasovskikh vlasovskikh self-assigned this Sep 14, 2018
@johnlinp
Copy link
Contributor Author

@johnlinp johnlinp commented Sep 14, 2018

Sure. I'll be working on it.

Loading

@johnlinp
Copy link
Contributor Author

@johnlinp johnlinp commented Sep 17, 2018

@vlasovskikh Hi, I added 2 unit tests in SearchGroupTest. Please take a look. Thanks!

Loading

StringHelper.containsUpperCase should return true when one of
the character of the input string satisfies the following two
conditions:

1. The character is upper case.
2. The character is not prefixed with a backslash.

Before this fix, the second condition was incorrectly written.
@vlasovskikh vlasovskikh merged commit b6be262 into JetBrains:master Sep 21, 2018
@vlasovskikh
Copy link
Member

@vlasovskikh vlasovskikh commented Sep 21, 2018

@johnlinp Thank you! I've merged it.

Loading

@johnlinp johnlinp deleted the vim-1274 branch Sep 22, 2018
@johnlinp
Copy link
Contributor Author

@johnlinp johnlinp commented Sep 25, 2018

@vlasovskikh May I ask the next release date?

Loading

@vlasovskikh
Copy link
Member

@vlasovskikh vlasovskikh commented Sep 30, 2018

@johnlinp A EAP build containing the fix will be available soon. The next release will likely appear in a month or so.

Loading

@johnlinp
Copy link
Contributor Author

@johnlinp johnlinp commented Oct 1, 2018

@vlasovskikh Great! Looking forward to it.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants