Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing '{' - '?' - '}' results in "{?}}" #234

Closed
tonyxty opened this issue Sep 28, 2020 · 1 comment · Fixed by #236
Closed

Typing '{' - '?' - '}' results in "{?}}" #234

tonyxty opened this issue Sep 28, 2020 · 1 comment · Fixed by #236
Assignees
@ice1000
Labels
lexer typed goal typed handler
Milestone
1.5

Comments

@tonyxty
Copy link

tonyxty commented Sep 28, 2020

This is a minor nuisance, but it's curious to note that IDEA itself (and other intellij-based IDEs) handle this situation properly.
@ice1000 ice1000 self-assigned this Sep 28, 2020
@ice1000 ice1000 added this to the 1.5 milestone Sep 28, 2020
@ice1000
Copy link
Collaborator

ice1000 commented Sep 28, 2020

I see the problem. It's because that {?} is a standalone complete token.

@ice1000 ice1000 removed this from the 1.5 milestone Sep 28, 2020
@ice1000 ice1000 added the lexer label Sep 28, 2020
@ice1000 ice1000 mentioned this issue Sep 28, 2020
Closed
ice1000 added a commit that referenced this issue Sep 28, 2020
@ice1000
Remove TGOAL, fixes #234
31f9c8a
ice1000 added a commit that referenced this issue Sep 28, 2020
@ice1000
Add test fixture for #234
d8296a1
ice1000 added a commit that referenced this issue Sep 28, 2020
@ice1000
Add test fixture for #234
4e13556
@ice1000 ice1000 mentioned this issue Sep 28, 2020
Merged
@valis valis closed this as completed in 4589651 Sep 28, 2020
@ice1000 ice1000 added this to the 1.5 milestone Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ice1000 ice1000

Labels
lexer typed goal typed handler
Projects
None yet
Milestone
1.5
2 participants
@tonyxty @ice1000