Revise SSH URL checker to allow '@' and ':' in path - #2523
Closed
W. Michael Petullo (flyn-org) wants to merge 1 commit into
Closed
W. Michael Petullo (flyn-org) wants to merge 1 commit into
W. Michael Petullo (flyn-org) wants to merge 1 commit into
Conversation
RFC 3986 allows '@' and ':' characters in the path component of a URL, but SSH_URL_PATTERN did not. This revises SSH_URL_PATTERN to allow these characters, so that Intellij supports URLs of the following form: user_at_example_dot_com@example.com:/home/user@example.com/project See also https://youtrack.jetbrains.com/issue/IDEA-326235. Signed-off-by: W. Michael Petullo <mike@flyn.org>
Contributor
Author
|
Aleksandr Krasilnikov (@a-krasilnikov), do you have any comment on this proposal? |
Contributor
Author
|
I teach an undergraduate class that would benefit from fixing this. Right now, the students must clone on the command line rather than from within IntelliJ IDEA because of the presence of '@' in the class's Git URLs. ybedrov, Kirill Likhodedov (@klikh), and Aleksandr Krasilnikov (@a-krasilnikov), might it be possible to address this before our next semester? I am happy to help test the final solution. |
Contributor
|
W. Michael Petullo (@flyn-org) Thank you for the contribution. We've merged the pull request. And thanks for reminding. |
Contributor
Author
|
Confirmed shipped in idea-IC-241.14494.240 (ideaIC-2024.1.tar.gz). This is great. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 3986 allows '@' and ':' characters in the path component of a URL, but SSH_URL_PATTERN did not. This revises SSH_URL_PATTERN to allow these characters, so that Intellij supports URLs of the following form:
user_at_example_dot_com@example.com:/home/user@example.com/project
See also https://youtrack.jetbrains.com/issue/IDEA-326235.