Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for SCL-11344 (apply inherited from generic trait) #376

Conversation

@greenjoe
Copy link
Contributor

@greenjoe greenjoe commented Apr 4, 2017

  • I modified lines that handled curly brace imports in ScImportStmtImpl but appeared to have completely no effect (boolean result was ignored) - I believe I made the behavior similar to singular imports
  • Added test for SCL-11344 in ApplyTest.scala

I've spent a few days trying to find the source of this bug and I am still not sure whether it is a good way to fix it and if there might be negative performance implications. I don't think I can do any better though so I thought it might be a good idea to just create a pull request and find out if the change makes any sense :-) The lines I changed in ScImportStmtImpl seemed really suspicious, so even if the fix is not appropriate I believe it's worth to take a look at the code there :-)

* Modified lines that handled curly brace imports in ScImportStmtImpl
but appeared to have completely no effect (boolean result was ignored)
- made behavior similar to singular imports
* Added test for SCL-11344 in ApplyTest.scala
#SCL-11344 fixed
niktrop added a commit that referenced this pull request Apr 11, 2017
check for imported names should not be ignored
+ minor refactoring
#SCL-11344 fixed

based on #376
@niktrop
Copy link
Contributor

@niktrop niktrop commented Apr 11, 2017

Thank you for pointing to the issue. I imagine that it was hard to find it. You may have a look to the fix: d8d1a54

@niktrop niktrop closed this Apr 11, 2017
adkozlov added a commit that referenced this pull request Apr 14, 2017
check for imported names should not be ignored
+ minor refactoring
#SCL-11344 fixed

based on #376
Lugzan added a commit that referenced this pull request Apr 17, 2017
check for imported names should not be ignored
+ minor refactoring
#SCL-11344 fixed

based on #376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.