Fix for SCL-11344 (apply inherited from generic trait) #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Modified lines that handled curly brace imports in ScImportStmtImpl but appeared to have completely no effect (boolean result was ignored) - made behavior similar to singular imports * Added test for SCL-11344 in ApplyTest.scala #SCL-11344 fixed
niktrop
added a commit
that referenced
this pull request
Apr 11, 2017
check for imported names should not be ignored + minor refactoring #SCL-11344 fixed based on #376
|
Thank you for pointing to the issue. I imagine that it was hard to find it. You may have a look to the fix: d8d1a54 |
adkozlov
pushed a commit
that referenced
this pull request
Apr 14, 2017
check for imported names should not be ignored + minor refactoring #SCL-11344 fixed based on #376
Lugzan
pushed a commit
that referenced
this pull request
Apr 17, 2017
check for imported names should not be ignored + minor refactoring #SCL-11344 fixed based on #376
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've spent a few days trying to find the source of this bug and I am still not sure whether it is a good way to fix it and if there might be negative performance implications. I don't think I can do any better though so I thought it might be a good idea to just create a pull request and find out if the change makes any sense :-) The lines I changed in ScImportStmtImpl seemed really suspicious, so even if the fix is not appropriate I believe it's worth to take a look at the code there :-)