Fix IfElseToFilteredOptionInspection shortName #414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm... I can merge this. The question is, if it is worth fixing the typo in comparison to that we would destroy every disabled warning comment for users downstream... |
|
@SrTobi Good catch, I think it's better to keep it as is. But you also have to make the same typo in |
SrTobi
added a commit
that referenced
this pull request
Jan 16, 2019
…rtname The typo in the html page's name is deliberate. We did not want to fix the actual typo in the shortname, because that would break disabling-comments for users downstream. See #414 SCL-10175
JetBrainsTeamCity
pushed a commit
that referenced
this pull request
Jan 16, 2019
…rtname The typo in the html page's name is deliberate. We did not want to fix the actual typo in the shortname, because that would break disabling-comments for users downstream. See #414 SCL-10175
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.