Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS Test Examples: Move from gradle plugin com.moowork.node to de.solugo.gradle.nodejs #85

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@SalomonBrys
Copy link

SalomonBrys commented May 28, 2018

The com.moowork.node gradle plugin is incompatible with Gradle 4.6 when GRADLE_METADATA is used. This makes it fail when used with plugins that use this feature, such as Kotlin/Native konan gradle plugin.

Therefore, when creating a multi-platform project, using the provided examples do not work.

In this PR, I propose to replace this gradle plugin with the de.solugo.gradle.nodejs plugin, which works as expected on gradle 4.6+.

This will provide examples that work in pure Kotlin/JS projects, but also in Kotlin/Everywhere projects.

Note that the karma example is untouched and is the only one that will continue to fail: the example uses the com.craigburke.karma gradle plugin, which itself depends on com.moowork.node.

This PR fixes the jasmine, jest, mocha, qunit and jest examples.

@m19cc

m19cc approved these changes Nov 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.