Kotlin daemon JVM args - clearing up inheritance and defaults #4454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaeawc
force-pushed
the
kaeawc/update-jvm-arg-docs
branch
from
1ce36cf to
f2db1cf
Compare
kaeawc
force-pushed
the
kaeawc/update-jvm-arg-docs
branch
2 times, most recently
from
6e8e09c to
5e34300
Compare
ALikhachev
requested changes
Sep 24, 2024
kaeawc
force-pushed
the
kaeawc/update-jvm-arg-docs
branch
from
a63df40 to
4b2242b
Compare
Contributor
Author
|
@sarahhaggarty is there anything else you'd want me to change in this PR? |
ALikhachev
approved these changes
Oct 7, 2024
Contributor
Author
|
@sarahhaggarty @danil-pavlov just wanted to bump this issue, what might next steps be? |
Collaborator
|
Hi @kaeawc! |
Contributor
Author
|
Thanks and all good. 😄 |
sarahhaggarty
requested changes
Oct 28, 2024
Collaborator
sarahhaggarty
left a comment
sarahhaggarty
left a comment
There was a problem hiding this comment.
Thanks for your suggestions @kaeawc!
I've made some suggestions to update the text based on our style guidelines. Can you update your PR? Please let me know if you need any assistance or if something isn't clear to you.
Contributor
Author
|
@sarahhaggarty I added all your suggestions and updated the branch with latest |
Co-authored-by: Alex Likhachev <ALikhachev@users.noreply.github.com>
Co-authored-by: Alex Likhachev <ALikhachev@users.noreply.github.com>
Co-authored-by: Sarah Haggarty <81160244+sarahhaggarty@users.noreply.github.com>
sarahhaggarty
force-pushed
the
kaeawc/update-jvm-arg-docs
branch
from
028a387 to
a2a21e4
Compare
sarahhaggarty
approved these changes
Nov 4, 2024
Collaborator
|
Thanks for your contribution @kaeawc ! |
zamulla
pushed a commit
that referenced
this pull request
Nov 13, 2024
* add notes about jvm inheritance and defaults for kotlin daemon * Update docs/topics/gradle/gradle-compilation-and-caches.md Co-authored-by: Alex Likhachev <ALikhachev@users.noreply.github.com> * Update docs/topics/gradle/gradle-compilation-and-caches.md Co-authored-by: Alex Likhachev <ALikhachev@users.noreply.github.com> * remove arg that is not actually a default * apply Writerside update for callouts * Apply suggestions from code review Co-authored-by: Sarah Haggarty <81160244+sarahhaggarty@users.noreply.github.com> --------- Co-authored-by: Alex Likhachev <ALikhachev@users.noreply.github.com> Co-authored-by: Sarah Haggarty <81160244+sarahhaggarty@users.noreply.github.com>
danil-pavlov
pushed a commit
that referenced
this pull request
Nov 18, 2024
* add notes about jvm inheritance and defaults for kotlin daemon * Update docs/topics/gradle/gradle-compilation-and-caches.md Co-authored-by: Alex Likhachev <ALikhachev@users.noreply.github.com> * Update docs/topics/gradle/gradle-compilation-and-caches.md Co-authored-by: Alex Likhachev <ALikhachev@users.noreply.github.com> * remove arg that is not actually a default * apply Writerside update for callouts * Apply suggestions from code review Co-authored-by: Sarah Haggarty <81160244+sarahhaggarty@users.noreply.github.com> --------- Co-authored-by: Alex Likhachev <ALikhachev@users.noreply.github.com> Co-authored-by: Sarah Haggarty <81160244+sarahhaggarty@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I filed KT-71564 the other day because my previous understanding (and that of some of the AndroidX team) was that all Gradle JVM args would be inherited if no Kotlin JVM args were specified. I did some digging in the Kotlin Gradle Plugin and Kotlin Daemon sources to find how that process works and think this should clear everything up.